GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: remove conditional assignment in custom ESLint rule · nodejs/node@dcada80

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

tools/eslint-rules
- no-duplicate-requires.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎tools/eslint-rules/no-duplicate-requires.js‎`

Copy file name to clipboardExpand all lines: tools/eslint-rules/no-duplicate-requires.js

+10-9Lines changed: 10 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,18 +10,19 @@ const { isRequireCall, isString } = require('./rules-utils.js');`
`10`	`10`	`// Rule Definition`
`11`	`11`	`//------------------------------------------------------------------------------`
`12`	`12`
	`13`	`+const secondLevelTypes = [`
	`14`	`+ 'FunctionDeclaration', 'FunctionExpression', 'ArrowFunctionExpression',`
	`15`	`+ 'ClassBody', 'MethodDefinition',`
	`16`	`+];`
`13`	`17`
`14`	`18`	`function isTopLevel(node) {`
`15`		`- do {`
`16`		`- if (node.type === 'FunctionDeclaration' \|\|`
`17`		`- node.type === 'FunctionExpression' \|\|`
`18`		`- node.type === 'ArrowFunctionExpression' \|\|`
`19`		`- node.type === 'ClassBody' \|\|`
`20`		`- node.type === 'MethodDefinition') {`
`21`		`- return false;`
	`19`	`+ while (!secondLevelTypes.includes(node.type)) {`
	`20`	`+ node = node.parent;`
	`21`	`+ if (!node) {`
	`22`	`+ return true;`
`22`	`23`	`}`
`23`		`- } while (node = node.parent);`
`24`		`- return true;`
	`24`	`+ }`
	`25`	`+ return false;`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`module.exports = (context) => {`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.