GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: remove usages of GetBackingStore in WASI · nodejs/node@ddf9c16

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_wasi.cc
- node_wasm_web_api.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_wasi.cc‎`

Copy file name to clipboardExpand all lines: src/node_wasi.cc

+3-5Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,6 @@ inline void Debug(WASI* wasi, Args&&... args) {`
`73`	`73`	`} while (0)`
`74`	`74`
`75`	`75`	`using v8::Array;`
`76`		`-using v8::BackingStore;`
`77`	`76`	`using v8::BigInt;`
`78`	`77`	`using v8::Context;`
`79`	`78`	`using v8::Exception;`
`@@ -1654,10 +1653,9 @@ void WASI::_SetMemory(const FunctionCallbackInfo<Value>& args) {`
`1654`	`1653`
`1655`	`1654`	`uvwasi_errno_t WASI::backingStore(char** store, size_t* byte_length) {`
`1656`	`1655`	`Local<WasmMemoryObject> memory = PersistentToLocal::Strong(this->memory_);`
`1657`		`- std::shared_ptr<BackingStore> backing_store =`
`1658`		`- memory->Buffer()->GetBackingStore();`
`1659`		`- *byte_length = backing_store->ByteLength();`
`1660`		`- store = static_cast<char>(backing_store->Data());`
	`1656`	`+ Local<v8::ArrayBuffer> ab = memory->Buffer();`
	`1657`	`+ *byte_length = ab->ByteLength();`
	`1658`	`+ store = static_cast<char>(ab->Data());`
`1661`	`1659`	`CHECK_NOT_NULL(*store);`
`1662`	`1660`	`return UVWASI_ESUCCESS;`
`1663`	`1661`	`}`

Collapse file

`‎src/node_wasm_web_api.cc‎`

Copy file name to clipboardExpand all lines: src/node_wasm_web_api.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -105,12 +105,12 @@ void WasmStreamingObject::Push(const FunctionCallbackInfo<Value>& args) {`
`105`	`105`
`106`	`106`	`if (LIKELY(chunk->IsArrayBufferView())) {`
`107`	`107`	`Local<ArrayBufferView> view = chunk.As<ArrayBufferView>();`
`108`		`- bytes = view->Buffer()->GetBackingStore()->Data();`
	`108`	`+ bytes = view->Buffer()->Data();`
`109`	`109`	`offset = view->ByteOffset();`
`110`	`110`	`size = view->ByteLength();`
`111`	`111`	`} else if (LIKELY(chunk->IsArrayBuffer())) {`
`112`	`112`	`Local<ArrayBuffer> buffer = chunk.As<ArrayBuffer>();`
`113`		`- bytes = buffer->GetBackingStore()->Data();`
	`113`	`+ bytes = buffer->Data();`
`114`	`114`	`offset = 0;`
`115`	`115`	`size = buffer->ByteLength();`
`116`	`116`	`} else {`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.