GeezerVison is showing github.com — build: fix update-wpt workflow · nodejs/node@de48407
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: .github/workflows/update-wpt.yml +5-1Lines changed: 5 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
70 | 70 | - name: Open or update PR for the subsystem update |
71 | 71 | uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5 |
72 | 72 | with: |
73 | | - branch: actions/update-wpt-${{ matrix.subsystem }} |
| 73 | + # The create-or-update-pull-request-action matches the branch name by prefix, |
| 74 | + # which is why we need to add the -wpt suffix. If we dont do that, we risk matching wrong PRs, |
| 75 | + # like for example "url" mistakenly matching and updating the "urlpattern" PR |
| 76 | + # as seen in https://github.com/nodejs/node/pull/57368 |
| 77 | + branch: actions/update-${{ matrix.subsystem }}-wpt |
74 | 78 | |
75 | 79 | title: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}' |
76 | 80 | commit-message: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}' |
|