GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "deps: always define V8_EXPORT_PRIVATE as no-op" · nodejs/node@e3193ee

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

common.gypi
deps/v8/src/base
- macros.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎common.gypi‎`

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@`
`38`	`38`
`39`	`39`	`# Reset this number to 0 on major V8 upgrades.`
`40`	`40`	`# Increment by one for each non-official patch applied to deps/v8.`
`41`		`- 'v8_embedder_string': '-node.11',`
	`41`	`+ 'v8_embedder_string': '-node.12',`
`42`	`42`
`43`	`43`	`##### V8 defaults for Node.js #####`
`44`	`44`

Collapse file

`‎deps/v8/src/base/macros.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/base/macros.h

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -442,9 +442,9 @@ bool is_inbounds(float_t v) {`
`442`	`442`	`// Setup for Windows shared library export.`
`443`	`443`	`#define V8_EXPORT_ENUM`
`444`	`444`	`#ifdef BUILDING_V8_SHARED_PRIVATE`
`445`		`-#define V8_EXPORT_PRIVATE`
	`445`	`+#define V8_EXPORT_PRIVATE __declspec(dllexport)`
`446`	`446`	`#elif USING_V8_SHARED_PRIVATE`
`447`		`-#define V8_EXPORT_PRIVATE`
	`447`	`+#define V8_EXPORT_PRIVATE __declspec(dllimport)`
`448`	`448`	`#else`
`449`	`449`	`#define V8_EXPORT_PRIVATE`
`450`	`450`	`#endif // BUILDING_V8_SHARED`
`@@ -454,7 +454,7 @@ bool is_inbounds(float_t v) {`
`454`	`454`	`// Setup for Linux shared library export.`
`455`	`455`	`#if V8_HAS_ATTRIBUTE_VISIBILITY && \`
`456`	`456`	`(defined(BUILDING_V8_SHARED_PRIVATE) \|\| USING_V8_SHARED_PRIVATE)`
`457`		`-#define V8_EXPORT_PRIVATE`
	`457`	`+#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))`
`458`	`458`	`#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE`
`459`	`459`	`#else`
`460`	`460`	`#define V8_EXPORT_PRIVATE`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.