GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — errors: handle V8 warnings in DisallowJavascriptExecutionScope · nodejs/node@e4e5137

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_errors.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_errors.cc‎`

Copy file name to clipboardExpand all lines: src/node_errors.cc

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1064,7 +1064,12 @@ void PerIsolateMessageListener(Local<Message> message, Local<Value> error) {`
`1064`	`1064`	`filename,`
`1065`	`1065`	`message->GetLineNumber(env->context()).FromMaybe(-1),`
`1066`	`1066`	`msg);`
`1067`		`- USE(ProcessEmitWarningGeneric(env, warning, "V8"));`
	`1067`	`+ // Defer the warning to the next event loop iteration. This prevents`
	`1068`	`+ // crashes when V8 emits warnings during code evaluation with`
	`1069`	`+ // throwOnSideEffect.`
	`1070`	`+ env->SetImmediate([warning](Environment* env) {`
	`1071`	`+ ProcessEmitWarningGeneric(env, warning, "V8");`
	`1072`	`+ });`
`1068`	`1073`	`break;`
`1069`	`1074`	`}`
`1070`	`1075`	`case Isolate::MessageErrorLevel::kMessageError:`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.