GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — events: add hasEventListener util for validate · nodejs/node@e87db6c

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib
    • events.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/events.js‎

Copy file name to clipboardExpand all lines: lib/events.js
+12-12Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,12 @@ ObjectDefineProperty(EventEmitter, 'defaultMaxListeners', {
287287
},
288288
});
289289

290+
function hasEventListener(self, type) {
291+
if (type === undefined)
292+
return self._events !== undefined;
293+
return self._events !== undefined && self._events[type] !== undefined;
294+
}
295+
290296
ObjectDefineProperties(EventEmitter, {
291297
kMaxEventTargetListeners: {
292298
__proto__: null,
@@ -680,13 +686,11 @@ EventEmitter.prototype.removeListener =
680686
function removeListener(type, listener) {
681687
checkListener(listener);
682688

683-
const events = this._events;
684-
if (events === undefined)
689+
if (!hasEventListener(this, type))
685690
return this;
686691

692+
const events = this._events;
687693
const list = events[type];
688-
if (list === undefined)
689-
return this;
690694

691695
if (list === listener || list.listener === listener) {
692696
this._eventsCount -= 1;
@@ -742,9 +746,9 @@ EventEmitter.prototype.off = EventEmitter.prototype.removeListener;
742746
*/
743747
EventEmitter.prototype.removeAllListeners =
744748
function removeAllListeners(type) {
745-
const events = this._events;
746-
if (events === undefined)
749+
if (!hasEventListener(this))
747750
return this;
751+
const events = this._events;
748752

749753
// Not listening for removeListener, no need to emit
750754
if (events.removeListener === undefined) {
@@ -789,14 +793,10 @@ EventEmitter.prototype.removeAllListeners =
789793
};
790794

791795
function _listeners(target, type, unwrap) {
792-
const events = target._events;
793-
794-
if (events === undefined)
796+
if (!hasEventListener(target, type))
795797
return [];
796798

797-
const evlistener = events[type];
798-
if (evlistener === undefined)
799-
return [];
799+
const evlistener = target._events[type];
800800

801801
if (typeof evlistener === 'function')
802802
return unwrap ? [evlistener.listener || evlistener] : [evlistener];

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.