GeezerVison is showing github.com — Revert "http: headers(Distinct), trailers(Distinct) setters to be no-op" · nodejs/node@eac26c0
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: lib/_http_incoming.js +12-4Lines changed: 12 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -122,7 +122,9 @@ ObjectDefineProperty(IncomingMessage.prototype, 'headers', { | 122 | 122 | } | 123 | 123 | return this[kHeaders]; | 124 | 124 | }, | 125 | | - set: function(val) {} | | 125 | + set: function(val) { | | 126 | + this[kHeaders] = val; | | 127 | + } | 126 | 128 | }); | 127 | 129 |
| 128 | 130 | ObjectDefineProperty(IncomingMessage.prototype, 'headersDistinct', { | @@ -140,7 +142,9 @@ ObjectDefineProperty(IncomingMessage.prototype, 'headersDistinct', { | 140 | 142 | } | 141 | 143 | return this[kHeadersDistinct]; | 142 | 144 | }, | 143 | | - set: function(val) {} | | 145 | + set: function(val) { | | 146 | + this[kHeadersDistinct] = val; | | 147 | + } | 144 | 148 | }); | 145 | 149 |
| 146 | 150 | ObjectDefineProperty(IncomingMessage.prototype, 'trailers', { | @@ -158,7 +162,9 @@ ObjectDefineProperty(IncomingMessage.prototype, 'trailers', { | 158 | 162 | } | 159 | 163 | return this[kTrailers]; | 160 | 164 | }, | 161 | | - set: function(val) {} | | 165 | + set: function(val) { | | 166 | + this[kTrailers] = val; | | 167 | + } | 162 | 168 | }); | 163 | 169 |
| 164 | 170 | ObjectDefineProperty(IncomingMessage.prototype, 'trailersDistinct', { | @@ -176,7 +182,9 @@ ObjectDefineProperty(IncomingMessage.prototype, 'trailersDistinct', { | 176 | 182 | } | 177 | 183 | return this[kTrailersDistinct]; | 178 | 184 | }, | 179 | | - set: function(val) {} | | 185 | + set: function(val) { | | 186 | + this[kTrailersDistinct] = val; | | 187 | + } | 180 | 188 | }); | 181 | 189 |
| 182 | 190 | IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) { | |
Collapse file Copy file name to clipboardExpand all lines: test/parallel/test-http-set-headers-distinct.js -54Lines changed: 0 additions & 54 deletions Collapse file Copy file name to clipboardExpand all lines: test/parallel/test-set-incoming-message-header.js +6-5Lines changed: 6 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -4,23 +4,24 @@ require('../common'); | 4 | 4 | const { IncomingMessage } = require('http'); | 5 | 5 | const assert = require('assert'); | 6 | 6 |
| 7 | | -// Headers setter should be a No-Op | | 7 | +// Headers setter function set a header correctly | 8 | 8 | { | 9 | 9 | const im = new IncomingMessage(); | 10 | 10 | im.headers = { key: 'value' }; | 11 | | - assert.deepStrictEqual(im.headers, {}); | | 11 | + assert.deepStrictEqual(im.headers, { key: 'value' }); | 12 | 12 | } | 13 | 13 |
| 14 | | -// Trailers setter should be a No-Op | | 14 | +// Trailers setter function set a header correctly | 15 | 15 | { | 16 | 16 | const im = new IncomingMessage(); | 17 | 17 | im.trailers = { key: 'value' }; | 18 | | - assert.deepStrictEqual(im.trailers, {}); | | 18 | + assert.deepStrictEqual(im.trailers, { key: 'value' }); | 19 | 19 | } | 20 | 20 |
| 21 | 21 | // _addHeaderLines function set a header correctly | 22 | 22 | { | 23 | 23 | const im = new IncomingMessage(); | | 24 | + im.headers = { key1: 'value1' }; | 24 | 25 | im._addHeaderLines(['key2', 'value2'], 2); | 25 | | - assert.deepStrictEqual(im.headers, { key2: 'value2' }); | | 26 | + assert.deepStrictEqual(im.headers, { key1: 'value1', key2: 'value2' }); | 26 | 27 | } |
|