GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix memory leaks in runner · nodejs/node@ec1cbbe

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib/internal/test_runner
    • runner.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/internal/test_runner/runner.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/runner.js
+19-6Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,9 @@ function runTestFile(path, filesWatcher, opts) {
460460
finished(child.stdout, { __proto__: null, signal: t.signal }),
461461
]);
462462

463+
// Close readline interface to prevent memory leak
464+
rl.close();
465+
463466
if (watchMode) {
464467
filesWatcher.runningProcesses.delete(path);
465468
filesWatcher.runningSubtests.delete(path);
@@ -522,7 +525,7 @@ function watchFiles(testFiles, opts) {
522525
}
523526

524527
// Watch for changes in current filtered files
525-
watcher.on('changed', ({ owners, eventType }) => {
528+
const onChanged = ({ owners, eventType }) => {
526529
if (!opts.hasFiles && (eventType === 'rename' || eventType === 'change')) {
527530
const updatedTestFiles = createTestFileList(opts.globPatterns, opts.cwd);
528531
const newFileName = ArrayPrototypeFind(updatedTestFiles, (x) => !ArrayPrototypeIncludes(testFiles, x));
@@ -563,19 +566,29 @@ function watchFiles(testFiles, opts) {
563566
triggerUncaughtException(error, true /* fromPromise */);
564567
}));
565568
}
566-
});
569+
};
570+
571+
watcher.on('changed', onChanged);
572+
573+
// Cleanup function to remove event listener and prevent memory leak
574+
const cleanup = () => {
575+
watcher.removeListener('changed', onChanged);
576+
opts.root.harness.watching = false;
577+
opts.root.postRun();
578+
};
579+
567580
if (opts.signal) {
568581
kResistStopPropagation ??= require('internal/event_target').kResistStopPropagation;
569582
opts.signal.addEventListener(
570583
'abort',
571-
() => {
572-
opts.root.harness.watching = false;
573-
opts.root.postRun();
574-
},
584+
cleanup,
575585
{ __proto__: null, once: true, [kResistStopPropagation]: true },
576586
);
577587
}
578588

589+
// Expose cleanup method for proper resource management
590+
filesWatcher.cleanup = cleanup;
591+
579592
return filesWatcher;
580593
}
581594

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.