GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: use `enum class` instead of `enum` in node_i18n · nodejs/node@ed0a867

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_i18n.cc
- node_i18n.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_i18n.cc‎`

Copy file name to clipboardExpand all lines: src/node_i18n.cc

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -642,13 +642,13 @@ int32_t ToUnicode(MaybeStackBuffer<char>* buf,`
`642`	`642`	`int32_t ToASCII(MaybeStackBuffer<char>* buf,`
`643`	`643`	`const char* input,`
`644`	`644`	`size_t length,`
`645`		`- enum idna_mode mode) {`
	`645`	`+ idna_mode mode) {`
`646`	`646`	`UErrorCode status = U_ZERO_ERROR;`
`647`	`647`	`uint32_t options = // CheckHyphens = false; handled later`
`648`	`648`	`UIDNA_CHECK_BIDI \| // CheckBidi = true`
`649`	`649`	`UIDNA_CHECK_CONTEXTJ \| // CheckJoiners = true`
`650`	`650`	`UIDNA_NONTRANSITIONAL_TO_ASCII; // Nontransitional_Processing`
`651`		`- if (mode == IDNA_STRICT) {`
	`651`	`+ if (mode == idna_mode::kStrict) {`
`652`	`652`	`options \|= UIDNA_USE_STD3_RULES; // UseSTD3ASCIIRules = beStrict`
`653`	`653`	`// VerifyDnsLength = beStrict;`
`654`	`654`	`// handled later`
`@@ -696,14 +696,14 @@ int32_t ToASCII(MaybeStackBuffer<char>* buf,`
`696`	`696`	`info.errors &= ~UIDNA_ERROR_LEADING_HYPHEN;`
`697`	`697`	`info.errors &= ~UIDNA_ERROR_TRAILING_HYPHEN;`
`698`	`698`
`699`		`- if (mode != IDNA_STRICT) {`
	`699`	`+ if (mode != idna_mode::kStrict) {`
`700`	`700`	`// VerifyDnsLength = beStrict`
`701`	`701`	`info.errors &= ~UIDNA_ERROR_EMPTY_LABEL;`
`702`	`702`	`info.errors &= ~UIDNA_ERROR_LABEL_TOO_LONG;`
`703`	`703`	`info.errors &= ~UIDNA_ERROR_DOMAIN_NAME_TOO_LONG;`
`704`	`704`	`}`
`705`	`705`
`706`		`- if (U_FAILURE(status) \|\| (mode != IDNA_LENIENT && info.errors != 0)) {`
	`706`	`+ if (U_FAILURE(status) \|\| (mode != idna_mode::kLenient && info.errors != 0)) {`
`707`	`707`	`len = -1;`
`708`	`708`	`buf->SetLength(0);`
`709`	`709`	`} else {`
`@@ -741,7 +741,7 @@ static void ToASCII(const FunctionCallbackInfo<Value>& args) {`
`741`	`741`	`Utf8Value val(env->isolate(), args[0]);`
`742`	`742`	`// optional arg`
`743`	`743`	`bool lenient = args[1]->BooleanValue(env->isolate());`
`744`		`- enum idna_mode mode = lenient ? IDNA_LENIENT : IDNA_DEFAULT;`
	`744`	`+ idna_mode mode = lenient ? idna_mode::kLenient : idna_mode::kDefault;`
`745`	`745`
`746`	`746`	`MaybeStackBuffer<char> buf;`
`747`	`747`	`int32_t len = ToASCII(&buf, *val, val.length(), mode);`

Collapse file

`‎src/node_i18n.h‎`

Copy file name to clipboardExpand all lines: src/node_i18n.h

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,23 +42,23 @@ bool InitializeICUDirectory(const std::string& path);`
`42`	`42`
`43`	`43`	`void SetDefaultTimeZone(const char* tzid);`
`44`	`44`
`45`		`-enum idna_mode {`
	`45`	`+enum class idna_mode {`
`46`	`46`	`// Default mode for maximum compatibility.`
`47`		`- IDNA_DEFAULT,`
	`47`	`+ kDefault,`
`48`	`48`	`// Ignore all errors in IDNA conversion, if possible.`
`49`		`- IDNA_LENIENT,`
	`49`	`+ kLenient,`
`50`	`50`	`// Enforce STD3 rules (UseSTD3ASCIIRules) and DNS length restrictions`
`51`	`51`	// (VerifyDnsLength). Corresponds to `beStrict` flag in the "domain to ASCII"
`52`	`52`	`// algorithm.`
`53`		`- IDNA_STRICT`
	`53`	`+ kStrict`
`54`	`54`	`};`
`55`	`55`
`56`	`56`	`// Implements the WHATWG URL Standard "domain to ASCII" algorithm.`
`57`	`57`	`// https://url.spec.whatwg.org/#concept-domain-to-ascii`
`58`	`58`	`int32_t ToASCII(MaybeStackBuffer<char>* buf,`
`59`	`59`	`const char* input,`
`60`	`60`	`size_t length,`
`61`		`- enum idna_mode mode = IDNA_DEFAULT);`
	`61`	`+ idna_mode mode = idna_mode::kDefault);`
`62`	`62`
`63`	`63`	`// Implements the WHATWG URL Standard "domain to Unicode" algorithm.`
`64`	`64`	`// https://url.spec.whatwg.org/#concept-domain-to-unicode`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.