GeezerVison is showing github.com — src: remove separate definitions for static constexpr members · nodejs/node@eeb3a68
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/async_wrap.cc -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -151,9 +151,6 @@ void AsyncWrap::EmitAfter(Environment* env, double async_id) { |
151 | 151 | env->async_hooks_after_function()); |
152 | 152 | } |
153 | 153 |
|
154 | | -// TODO(addaleax): Remove once we're on C++17. |
155 | | -constexpr double AsyncWrap::kInvalidAsyncId; |
156 | | - |
157 | 154 | static void SetupHooks(const FunctionCallbackInfo<Value>& args) { |
158 | 155 | Environment* env = Environment::GetCurrent(args); |
159 | 156 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_blob.cc -2Lines changed: 0 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -482,8 +482,6 @@ InternalFieldInfo* BlobBindingData::Serialize(int index) { |
482 | 482 | return info; |
483 | 483 | } |
484 | 484 |
|
485 | | -constexpr FastStringKey BlobBindingData::type_name; |
486 | | - |
487 | 485 | void Blob::RegisterExternalReferences(ExternalReferenceRegistry* registry) { |
488 | 486 | registry->Register(Blob::New); |
489 | 487 | registry->Register(Blob::ToArrayBuffer); |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_file.cc -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -2449,9 +2449,6 @@ InternalFieldInfo* BindingData::Serialize(int index) { |
2449 | 2449 | return info; |
2450 | 2450 | } |
2451 | 2451 |
|
2452 | | -// TODO(addaleax): Remove once we're on C++17. |
2453 | | -constexpr FastStringKey BindingData::type_name; |
2454 | | - |
2455 | 2452 | void Initialize(Local<Object> target, |
2456 | 2453 | Local<Value> unused, |
2457 | 2454 | Local<Context> context, |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_http2.cc -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -3135,9 +3135,6 @@ void Http2State::MemoryInfo(MemoryTracker* tracker) const { |
3135 | 3135 | tracker->TrackField("root_buffer", root_buffer); |
3136 | 3136 | } |
3137 | 3137 |
|
3138 | | -// TODO(addaleax): Remove once we're on C++17. |
3139 | | -constexpr FastStringKey Http2State::type_name; |
3140 | | - |
3141 | 3138 | // Set up the process.binding('http2') binding. |
3142 | 3139 | void Initialize(Local<Object> target, |
3143 | 3140 | Local<Value> unused, |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_http_parser.cc -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -107,9 +107,6 @@ class BindingData : public BaseObject { |
107 | 107 | SET_MEMORY_INFO_NAME(BindingData) |
108 | 108 | }; |
109 | 109 |
|
110 | | -// TODO(addaleax): Remove once we're on C++17. |
111 | | -constexpr FastStringKey BindingData::type_name; |
112 | | - |
113 | 110 | // helper class for the Parser |
114 | 111 | struct StringPtr { |
115 | 112 | StringPtr() { |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_process_methods.cc -2Lines changed: 0 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -448,8 +448,6 @@ static void ReallyExit(const FunctionCallbackInfo<Value>& args) { |
448 | 448 |
|
449 | 449 | namespace process { |
450 | 450 |
|
451 | | -constexpr FastStringKey BindingData::type_name; |
452 | | - |
453 | 451 | BindingData::BindingData(Environment* env, v8::Local<v8::Object> object) |
454 | 452 | : SnapshotableObject(env, object, type_int) { |
455 | 453 | Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), kBufferSize); |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_v8.cc -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -142,9 +142,6 @@ void BindingData::MemoryInfo(MemoryTracker* tracker) const { |
142 | 142 | heap_code_statistics_buffer); |
143 | 143 | } |
144 | 144 |
|
145 | | -// TODO(addaleax): Remove once we're on C++17. |
146 | | -constexpr FastStringKey BindingData::type_name; |
147 | | - |
148 | 145 | void CachedDataVersionTag(const FunctionCallbackInfo<Value>& args) { |
149 | 146 | Environment* env = Environment::GetCurrent(args); |
150 | 147 | Local<Integer> result = |
|