GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove separate definitions for static constexpr members · nodejs/node@eeb3a68

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • src
    • async_wrap.cc
    • node_blob.cc
    • node_file.cc
    • node_http2.cc
    • node_http_parser.cc
    • node_process_methods.cc
    • node_v8.cc
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/async_wrap.cc‎

Copy file name to clipboardExpand all lines: src/async_wrap.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,6 @@ void AsyncWrap::EmitAfter(Environment* env, double async_id) {
151151
env->async_hooks_after_function());
152152
}
153153

154-
// TODO(addaleax): Remove once we're on C++17.
155-
constexpr double AsyncWrap::kInvalidAsyncId;
156-
157154
static void SetupHooks(const FunctionCallbackInfo<Value>& args) {
158155
Environment* env = Environment::GetCurrent(args);
159156

Collapse file

‎src/node_blob.cc‎

Copy file name to clipboardExpand all lines: src/node_blob.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -482,8 +482,6 @@ InternalFieldInfo* BlobBindingData::Serialize(int index) {
482482
return info;
483483
}
484484

485-
constexpr FastStringKey BlobBindingData::type_name;
486-
487485
void Blob::RegisterExternalReferences(ExternalReferenceRegistry* registry) {
488486
registry->Register(Blob::New);
489487
registry->Register(Blob::ToArrayBuffer);
Collapse file

‎src/node_file.cc‎

Copy file name to clipboardExpand all lines: src/node_file.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2449,9 +2449,6 @@ InternalFieldInfo* BindingData::Serialize(int index) {
24492449
return info;
24502450
}
24512451

2452-
// TODO(addaleax): Remove once we're on C++17.
2453-
constexpr FastStringKey BindingData::type_name;
2454-
24552452
void Initialize(Local<Object> target,
24562453
Local<Value> unused,
24572454
Local<Context> context,
Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3135,9 +3135,6 @@ void Http2State::MemoryInfo(MemoryTracker* tracker) const {
31353135
tracker->TrackField("root_buffer", root_buffer);
31363136
}
31373137

3138-
// TODO(addaleax): Remove once we're on C++17.
3139-
constexpr FastStringKey Http2State::type_name;
3140-
31413138
// Set up the process.binding('http2') binding.
31423139
void Initialize(Local<Object> target,
31433140
Local<Value> unused,
Collapse file

‎src/node_http_parser.cc‎

Copy file name to clipboardExpand all lines: src/node_http_parser.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@ class BindingData : public BaseObject {
107107
SET_MEMORY_INFO_NAME(BindingData)
108108
};
109109

110-
// TODO(addaleax): Remove once we're on C++17.
111-
constexpr FastStringKey BindingData::type_name;
112-
113110
// helper class for the Parser
114111
struct StringPtr {
115112
StringPtr() {
Collapse file

‎src/node_process_methods.cc‎

Copy file name to clipboardExpand all lines: src/node_process_methods.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -448,8 +448,6 @@ static void ReallyExit(const FunctionCallbackInfo<Value>& args) {
448448

449449
namespace process {
450450

451-
constexpr FastStringKey BindingData::type_name;
452-
453451
BindingData::BindingData(Environment* env, v8::Local<v8::Object> object)
454452
: SnapshotableObject(env, object, type_int) {
455453
Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), kBufferSize);
Collapse file

‎src/node_v8.cc‎

Copy file name to clipboardExpand all lines: src/node_v8.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ void BindingData::MemoryInfo(MemoryTracker* tracker) const {
142142
heap_code_statistics_buffer);
143143
}
144144

145-
// TODO(addaleax): Remove once we're on C++17.
146-
constexpr FastStringKey BindingData::type_name;
147-
148145
void CachedDataVersionTag(const FunctionCallbackInfo<Value>& args) {
149146
Environment* env = Environment::GetCurrent(args);
150147
Local<Integer> result =

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.