GeezerVison is showing github.com — src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning · nodejs/node@ef7ffce
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/async_wrap.cc +2-10Lines changed: 2 additions & 10 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
25 | 25 | #include "env-inl.h" |
26 | 26 | #include "node_errors.h" |
27 | 27 | #include "node_external_reference.h" |
28 | | -#ifdef DEBUG |
29 | | -#include <node_process-inl.h> |
30 | | -#endif |
31 | 28 | #include "tracing/traced_value.h" |
32 | 29 | #include "util-inl.h" |
33 | 30 |
|
@@ -677,13 +674,8 @@ MaybeLocal<Value> AsyncWrap::MakeCallback(const Local<Function> cb, |
677 | 674 | Local<Value>* argv) { |
678 | 675 | EmitTraceEventBefore(); |
679 | 676 |
|
680 | | -#ifdef DEBUG |
681 | | - if (context_frame().IsEmpty()) { |
682 | | - ProcessEmitWarning(env(), |
683 | | - "MakeCallback() called without context_frame, " |
684 | | - "likely use after destroy of AsyncWrap."); |
685 | | - } |
686 | | -#endif |
| 677 | + // If this check fails it indicates an use after-free. |
| 678 | + DCHECK(!context_frame().IsEmpty()); |
687 | 679 |
|
688 | 680 | ProviderType provider = provider_type(); |
689 | 681 | async_context context { get_async_id(), get_trigger_async_id() }; |
|