GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — benchmark: use let instead of var in timers · nodejs/node@f172014

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

benchmark/timers

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎benchmark/timers/immediate.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/immediate.js

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ function main({ n, type }) {`
`31`	`31`
`32`	`32`	`// setImmediate tail recursion, 0 arguments`
`33`	`33`	`function depth(N) {`
`34`		`- var n = 0;`
	`34`	`+ let n = 0;`
`35`	`35`	`bench.start();`
`36`	`36`	`setImmediate(cb);`
`37`	`37`	`function cb() {`
`@@ -45,7 +45,7 @@ function depth(N) {`
`45`	`45`
`46`	`46`	`// setImmediate tail recursion, 1 argument`
`47`	`47`	`function depth1(N) {`
`48`		`- var n = 0;`
	`48`	`+ let n = 0;`
`49`	`49`	`bench.start();`
`50`	`50`	`setImmediate(cb, 1);`
`51`	`51`	`function cb(a1) {`
`@@ -59,7 +59,7 @@ function depth1(N) {`
`59`	`59`
`60`	`60`	`// Concurrent setImmediate, 0 arguments`
`61`	`61`	`function breadth(N) {`
`62`		`- var n = 0;`
	`62`	`+ let n = 0;`
`63`	`63`	`bench.start();`
`64`	`64`	`function cb() {`
`65`	`65`	`n++;`
`@@ -73,7 +73,7 @@ function breadth(N) {`
`73`	`73`
`74`	`74`	`// Concurrent setImmediate, 1 argument`
`75`	`75`	`function breadth1(N) {`
`76`		`- var n = 0;`
	`76`	`+ let n = 0;`
`77`	`77`	`bench.start();`
`78`	`78`	`function cb(a1) {`
`79`	`79`	`n++;`
`@@ -88,7 +88,7 @@ function breadth1(N) {`
`88`	`88`	`// Concurrent setImmediate, 4 arguments`
`89`	`89`	`function breadth4(N) {`
`90`	`90`	`N /= 2;`
`91`		`- var n = 0;`
	`91`	`+ let n = 0;`
`92`	`92`	`bench.start();`
`93`	`93`	`function cb(a1, a2, a3, a4) {`
`94`	`94`	`n++;`

Collapse file

`‎benchmark/timers/timers-breadth-args.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-breadth-args.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const bench = common.createBenchmark(main, {`
`6`	`6`	`});`
`7`	`7`
`8`	`8`	`function main({ n }) {`
`9`		`- var j = 0;`
	`9`	`+ let j = 0;`
`10`	`10`	`function cb1(arg1) {`
`11`	`11`	`j++;`
`12`	`12`	`if (j === n)`

Collapse file

`‎benchmark/timers/timers-breadth.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-breadth.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const bench = common.createBenchmark(main, {`
`6`	`6`	`});`
`7`	`7`
`8`	`8`	`function main({ n }) {`
`9`		`- var j = 0;`
	`9`	`+ let j = 0;`
`10`	`10`	`bench.start();`
`11`	`11`	`function cb() {`
`12`	`12`	`j++;`

Collapse file

`‎benchmark/timers/timers-cancel-pooled.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-cancel-pooled.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,11 +8,11 @@ const bench = common.createBenchmark(main, {`
`8`	`8`
`9`	`9`	`function main({ n }) {`
`10`	`10`
`11`		`- var timer = setTimeout(() => {}, 1);`
	`11`	`+ let timer = setTimeout(() => {}, 1);`
`12`	`12`	`for (let i = 0; i < n; i++) {`
`13`	`13`	`setTimeout(cb, 1);`
`14`	`14`	`}`
`15`		`- var next = timer._idlePrev;`
	`15`	`+ let next = timer._idlePrev;`
`16`	`16`	`clearTimeout(timer);`
`17`	`17`
`18`	`18`	`bench.start();`

Collapse file

`‎benchmark/timers/timers-cancel-unpooled.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-cancel-unpooled.js

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,14 +14,13 @@ function main({ n, direction }) {`
`14`	`14`	`timersList.push(setTimeout(cb, i + 1));`
`15`	`15`	`}`
`16`	`16`
`17`		`- var j;`
`18`	`17`	`bench.start();`
`19`	`18`	`if (direction === 'start') {`
`20`		`- for (j = 0; j < n; j++) {`
	`19`	`+ for (let j = 0; j < n; j++) {`
`21`	`20`	`clearTimeout(timersList[j]);`
`22`	`21`	`}`
`23`	`22`	`} else {`
`24`		`- for (j = n - 1; j >= 0; j--) {`
	`23`	`+ for (let j = n - 1; j >= 0; j--) {`
`25`	`24`	`clearTimeout(timersList[j]);`
`26`	`25`	`}`
`27`	`26`	`}`

Collapse file

`‎benchmark/timers/timers-depth.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-depth.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const bench = common.createBenchmark(main, {`
`6`	`6`	`});`
`7`	`7`
`8`	`8`	`function main({ n }) {`
`9`		`- var i = 0;`
	`9`	`+ let i = 0;`
`10`	`10`	`bench.start();`
`11`	`11`	`setTimeout(cb, 1);`
`12`	`12`	`function cb() {`

Collapse file

`‎benchmark/timers/timers-insert-unpooled.js‎`

Copy file name to clipboardExpand all lines: benchmark/timers/timers-insert-unpooled.js

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,14 +10,13 @@ const bench = common.createBenchmark(main, {`
`10`	`10`	`function main({ direction, n }) {`
`11`	`11`	`const timersList = [];`
`12`	`12`
`13`		`- var i;`
`14`	`13`	`bench.start();`
`15`	`14`	`if (direction === 'start') {`
`16`		`- for (i = 1; i <= n; i++) {`
	`15`	`+ for (let i = 1; i <= n; i++) {`
`17`	`16`	`timersList.push(setTimeout(cb, i));`
`18`	`17`	`}`
`19`	`18`	`} else {`
`20`		`- for (i = n; i > 0; i--) {`
	`19`	`+ for (let i = n; i > 0; i--) {`
`21`	`20`	`timersList.push(setTimeout(cb, i));`
`22`	`21`	`}`
`23`	`22`	`}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.