GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — url: handle unicode hostname if empty · nodejs/node@f256b16

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_url.cc
test/parallel
- test-url-format-whatwg.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_url.cc‎`

Copy file name to clipboardExpand all lines: src/node_url.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ void BindingData::Format(const FunctionCallbackInfo<Value>& args) {`
`168`	`168`	`out->hash = std::nullopt;`
`169`	`169`	`}`
`170`	`170`
`171`		`- if (unicode) {`
	`171`	`+ if (unicode && out->has_hostname()) {`
`172`	`172`	`out->host = ada::idna::to_unicode(out->get_hostname());`
`173`	`173`	`}`
`174`	`174`

Collapse file

`‎test/parallel/test-url-format-whatwg.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-url-format-whatwg.js

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -140,3 +140,8 @@ assert.strictEqual(`
`140`	`140`	`url.format(new URL('http://user:[email protected]:8080/path'), { unicode: true }),`
`141`	`141`	`'http://user:pass@测试.com:8080/path'`
`142`	`142`	`);`
	`143`	`+`
	`144`	`+assert.strictEqual(`
	`145`	`+ url.format(new URL('tel:123')),`
	`146`	`+ url.format(new URL('tel:123'), { unicode: true })`
	`147`	`+);`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.