GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — sqlite: enable defensive mode by default · nodejs/node@f289817

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/api
- sqlite.md
src
- node_sqlite.h
test/parallel
- test-sqlite-config.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/api/sqlite.md‎`

Copy file name to clipboardExpand all lines: doc/api/sqlite.md

+4-1Lines changed: 4 additions & 1 deletion

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,9 @@ exposed by this class execute synchronously.`
`104`	`104`	`<!-- YAML`
`105`	`105`	`added: v22.5.0`
`106`	`106`	`changes:`
	`107`	`+ - version: REPLACEME`
	`108`	`+ pr-url: https://github.com/nodejs/node/pull/61266`
	`109`	+ description: Enable `defensive` by default.
`107`	`110`	`- version:`
`108`	`111`	`- v25.1.0`
`109`	`112`	`pr-url: https://github.com/nodejs/node/pull/60217`
`@@ -153,7 +156,7 @@ changes:`
`153`	`156`	* `defensive` {boolean} If `true`, enables the defensive flag. When the defensive flag is enabled,
`154`	`157`	`language features that allow ordinary SQL to deliberately corrupt the database file are disabled.`
`155`	`158`	The defensive flag can also be set using `enableDefensive()`.
`156`		- Default: `false`.
	`159`	+ Default: `true`.
`157`	`160`
`158`	`161`	Constructs a new `DatabaseSync` instance.
`159`	`162`

Collapse file

`‎src/node_sqlite.h‎`

Copy file name to clipboardExpand all lines: src/node_sqlite.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ class DatabaseOpenConfiguration {`
`79`	`79`	`bool return_arrays_ = false;`
`80`	`80`	`bool allow_bare_named_params_ = true;`
`81`	`81`	`bool allow_unknown_named_params_ = false;`
`82`		`- bool defensive_ = false;`
	`82`	`+ bool defensive_ = true;`
`83`	`83`	`};`
`84`	`84`
`85`	`85`	`class DatabaseSync;`

Collapse file

`‎test/parallel/test-sqlite-config.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-sqlite-config.js

+10-3Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,9 @@ function checkDefensiveMode(db) {`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`-test('by default, defensive mode is off', (t) => {`
	`23`	`+test('by default, defensive mode is on', (t) => {`
`24`	`24`	`const db = new DatabaseSync(':memory:');`
`25`		`- t.assert.strictEqual(checkDefensiveMode(db), false);`
	`25`	`+ t.assert.strictEqual(checkDefensiveMode(db), true);`
`26`	`26`	`});`
`27`	`27`
`28`	`28`	`test('when passing { defensive: true } as config, defensive mode is on', (t) => {`
`@@ -32,13 +32,20 @@ test('when passing { defensive: true } as config, defensive mode is on', (t) =>`
`32`	`32`	`t.assert.strictEqual(checkDefensiveMode(db), true);`
`33`	`33`	`});`
`34`	`34`
	`35`	`+test('when passing { defensive: false } as config, defensive mode is off', (t) => {`
	`36`	`+ const db = new DatabaseSync(':memory:', {`
	`37`	`+ defensive: false`
	`38`	`+ });`
	`39`	`+ t.assert.strictEqual(checkDefensiveMode(db), false);`
	`40`	`+});`
	`41`	`+`
`35`	`42`	`test('defensive mode on after calling db.enableDefensive(true)', (t) => {`
`36`	`43`	`const db = new DatabaseSync(':memory:');`
`37`	`44`	`db.enableDefensive(true);`
`38`	`45`	`t.assert.strictEqual(checkDefensiveMode(db), true);`
`39`	`46`	`});`
`40`	`47`
`41`		`-test('defensive mode should be off after calling db.enableDefensive(false)', (t) => {`
	`48`	`+test('defensive mode off after calling db.enableDefensive(false)', (t) => {`
`42`	`49`	`const db = new DatabaseSync(':memory:', {`
`43`	`50`	`defensive: true`
`44`	`51`	`});`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.