GeezerVison is showing github.com — src: improve token return value check · nodejs/node@f35c91e
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/quic/tokens.cc +2-4Lines changed: 2 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -153,10 +153,9 @@ ngtcp2_vec GenerateRetryToken(uint8_t* buffer, |
153 | 153 | odcid, |
154 | 154 | uv_hrtime()); |
155 | 155 | DCHECK_GE(ret, 0); |
156 | | - DCHECK_LE(ret, RetryToken::kRetryTokenLen); |
157 | 156 | DCHECK_EQ(buffer[0], RetryToken::kTokenMagic); |
158 | 157 | // This shouldn't be possible but we handle it anyway just to be safe. |
159 | | - if (ret == 0) return {nullptr, 0}; |
| 158 | + if (ret <= 0) return {nullptr, 0}; |
160 | 159 | return {buffer, static_cast<size_t>(ret)}; |
161 | 160 | } |
162 | 161 |
|
@@ -172,10 +171,9 @@ ngtcp2_vec GenerateRegularToken(uint8_t* buffer, |
172 | 171 | address.length(), |
173 | 172 | uv_hrtime()); |
174 | 173 | DCHECK_GE(ret, 0); |
175 | | - DCHECK_LE(ret, RegularToken::kRegularTokenLen); |
176 | 174 | DCHECK_EQ(buffer[0], RegularToken::kTokenMagic); |
177 | 175 | // This shouldn't be possible but we handle it anyway just to be safe. |
178 | | - if (ret == 0) return {nullptr, 0}; |
| 176 | + if (ret <= 0) return {nullptr, 0}; |
179 | 177 | return {buffer, static_cast<size_t>(ret)}; |
180 | 178 | } |
181 | 179 | } // namespace |
|