GeezerVison is showing github.com — test: terminate WPT workers after test completion · nodejs/node@f7edb07
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: test/common/wpt.js +5Lines changed: 5 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -299,6 +299,7 @@ class WPTRunner { |
299 | 299 |
|
300 | 300 | this.results = {}; |
301 | 301 | this.inProgress = new Set(); |
| 302 | + this.workers = new Map(); |
302 | 303 | this.unexpectedFailures = []; |
303 | 304 | } |
304 | 305 |
|
@@ -376,6 +377,7 @@ class WPTRunner { |
376 | 377 | scriptsToRun, |
377 | 378 | }, |
378 | 379 | }); |
| 380 | + this.workers.set(testFileName, worker); |
379 | 381 |
|
380 | 382 | worker.on('message', (message) => { |
381 | 383 | switch (message.type) { |
@@ -501,6 +503,9 @@ class WPTRunner { |
501 | 503 | this.resultCallback(filename, { status: 2, name: 'Unknown' }); |
502 | 504 | } |
503 | 505 | this.inProgress.delete(filename); |
| 506 | + // Always force termination of the worker. Some tests allocate resources |
| 507 | + // that would otherwise keep it alive. |
| 508 | + this.workers.get(filename).terminate(); |
504 | 509 | } |
505 | 510 |
|
506 | 511 | addTestResult(filename, item) { |
|
Collapse file
Copy file name to clipboardExpand all lines: test/wpt/status/FileAPI/blob.json +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
1 | 1 | { |
2 | 2 | "Blob-constructor.any.js": { |
3 | | - "skip": "https://github.com/nodejs/node/issues/37358" |
| 3 | + "skip": "Depends on File API" |
4 | 4 | }, |
5 | 5 | "Blob-constructor-dom.window.js": { |
6 | 6 | "skip": "Depends on DOM API" |
|