GeezerVison is showing github.com — esm: fix typo `parentUrl` -> `parentURL` · nodejs/node@f96b610
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: lib/internal/modules/esm/initialize_import_meta.js +5-5Lines changed: 5 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -5,16 +5,16 @@ const experimentalImportMetaResolve = getOptionValue('--experimental-import-meta |
5 | 5 |
|
6 | 6 | /** |
7 | 7 | * Generate a function to be used as import.meta.resolve for a particular module. |
8 | | - * @param {string} defaultParentUrl The default base to use for resolution |
| 8 | + * @param {string} defaultParentURL The default base to use for resolution |
9 | 9 | * @param {typeof import('./loader.js').ModuleLoader} loader Reference to the current module loader |
10 | | - * @returns {(specifier: string, parentUrl?: string) => string} Function to assign to import.meta.resolve |
| 10 | + * @returns {(specifier: string, parentURL?: string) => string} Function to assign to import.meta.resolve |
11 | 11 | */ |
12 | | -function createImportMetaResolve(defaultParentUrl, loader) { |
13 | | - return function resolve(specifier, parentUrl = defaultParentUrl) { |
| 12 | +function createImportMetaResolve(defaultParentURL, loader) { |
| 13 | + return function resolve(specifier, parentURL = defaultParentURL) { |
14 | 14 | let url; |
15 | 15 |
|
16 | 16 | try { |
17 | | - ({ url } = loader.resolveSync(specifier, parentUrl)); |
| 17 | + ({ url } = loader.resolveSync(specifier, parentURL)); |
18 | 18 | } catch (error) { |
19 | 19 | if (error?.code === 'ERR_UNSUPPORTED_DIR_IMPORT') { |
20 | 20 | ({ url } = error); |
|
Collapse file
Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js +3-3Lines changed: 3 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -164,7 +164,7 @@ class ModuleLoader { |
164 | 164 | * string, parentURL: string, |
165 | 165 | * importAssertions: Record<string, string> |
166 | 166 | * ) ResolveResult; |
167 | | - * register(specifier: string, parentUrl: string): any; |
| 167 | + * register(specifier: string, parentURL: string): any; |
168 | 168 | * forceLoadHooks(): void; |
169 | 169 | * } |
170 | 170 | * ``` |
@@ -318,15 +318,15 @@ class ModuleLoader { |
318 | 318 | return module.getNamespace(); |
319 | 319 | } |
320 | 320 |
|
321 | | - register(specifier, parentUrl) { |
| 321 | + register(specifier, parentURL) { |
322 | 322 | if (!this.#customizations) { |
323 | 323 | // `CustomizedModuleLoader` is defined at the bottom of this file and |
324 | 324 | // available well before this line is ever invoked. This is here in |
325 | 325 | // order to preserve the git diff instead of moving the class. |
326 | 326 | // eslint-disable-next-line no-use-before-define |
327 | 327 | this.setCustomizations(new CustomizedModuleLoader()); |
328 | 328 | } |
329 | | - return this.#customizations.register(specifier, parentUrl); |
| 329 | + return this.#customizations.register(specifier, parentURL); |
330 | 330 | } |
331 | 331 |
|
332 | 332 | /** |
|