GeezerVison is showing github.com — src: create env->inspector_console_api_object earlier · nodejs/node@fa84e91
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/env.cc +7Lines changed: 7 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -241,6 +241,13 @@ void Environment::Start(const std::vector<std::string>& args, |
241 | 241 | static uv_once_t init_once = UV_ONCE_INIT; |
242 | 242 | uv_once(&init_once, InitThreadLocalOnce); |
243 | 243 | uv_key_set(&thread_local_env, this); |
| 244 | + |
| 245 | +#if HAVE_INSPECTOR |
| 246 | + // This needs to be set before we start the inspector |
| 247 | + Local<Object> obj = Object::New(isolate()); |
| 248 | + CHECK(obj->SetPrototype(context(), Null(isolate())).FromJust()); |
| 249 | + set_inspector_console_api_object(obj); |
| 250 | +#endif // HAVE_INSPECTOR |
244 | 251 | } |
245 | 252 |
|
246 | 253 | void Environment::RegisterHandleCleanups() { |
|
Collapse file
Copy file name to clipboardExpand all lines: src/inspector_agent.cc +1Lines changed: 1 addition & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -505,6 +505,7 @@ class NodeInspectorClient : public V8InspectorClient { |
505 | 505 | void installAdditionalCommandLineAPI(Local<Context> context, |
506 | 506 | Local<Object> target) override { |
507 | 507 | Local<Object> console_api = env_->inspector_console_api_object(); |
| 508 | + CHECK(!console_api.IsEmpty()); |
508 | 509 |
|
509 | 510 | Local<Array> properties = |
510 | 511 | console_api->GetOwnPropertyNames(context).ToLocalChecked(); |
|
Collapse file
Copy file name to clipboardExpand all lines: src/inspector_js_api.cc -6Lines changed: 0 additions & 6 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -277,12 +277,6 @@ void Url(const FunctionCallbackInfo<Value>& args) { |
277 | 277 | void Initialize(Local<Object> target, Local<Value> unused, |
278 | 278 | Local<Context> context, void* priv) { |
279 | 279 | Environment* env = Environment::GetCurrent(context); |
280 | | - { |
281 | | - auto obj = Object::New(env->isolate()); |
282 | | - auto null = Null(env->isolate()); |
283 | | - CHECK(obj->SetPrototype(context, null).FromJust()); |
284 | | - env->set_inspector_console_api_object(obj); |
285 | | - } |
286 | 280 |
|
287 | 281 | Agent* agent = env->inspector_agent(); |
288 | 282 | env->SetMethod(target, "consoleCall", InspectorConsoleCall); |
|