GeezerVison is showing github.com — doc: fix typos in contributing docs · nodejs/node@fab3f56
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: doc/contributing/first-contributions.md +1-1Lines changed: 1 addition & 1 deletion - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -21,7 +21,7 @@ If your first contribution is motivated by an issue you already encounter, but y | 21 | 21 | is complex, introduces a new feature, breaks backward compatibility, or needs a significant refactor, | 22 | 22 | it can be useful to open an issue to discuss whether the change or its design is acceptable before | 23 | 23 | working out the implementation details. The issue can be opened before you send the pull request, | 24 | | -or along side your pull request (in which case, it's better to keep the pull request in draft mode). | | 24 | +or alongside your pull request (in which case, it's better to keep the pull request in draft mode). | 25 | 25 |
| 26 | 26 | Straightforward or non-controversial changes, such as an obvious bug fix or a small refactor, don't | 27 | 27 | usually benefit from discussions in a separate issue, and can be sent directly as a pull request. | |
Collapse file Copy file name to clipboardExpand all lines: doc/contributing/pull-requests.md +1-1Lines changed: 1 addition & 1 deletion - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -459,7 +459,7 @@ commit. | 459 | 459 |
| 460 | 460 | If a pull request has been inactive for more than six months, add the `stalled` label | 461 | 461 | to it. That will trigger an automation that adds a comment explaining the pull request | 462 | | -may be close for inactivity, giving a heads-up to the contributor before actually | | 462 | +may be closed for inactivity, giving a heads-up to the contributor before actually | 463 | 463 | closing it if it remains inactive. | 464 | 464 |
| 465 | 465 | ### Approving a change | |
Collapse file Copy file name to clipboardExpand all lines: doc/contributing/writing-tests.md +1-1Lines changed: 1 addition & 1 deletion - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -345,7 +345,7 @@ when troubleshooting tests that timeout in CI. With no log statements, we have | 345 | 345 | no idea where the test got hung up. | 346 | 346 |
| 347 | 347 | There have been cases where tests fail without `console.log()`, and then pass | 348 | | -when its added, so be cautious about its use, particularly in tests of the I/O | | 348 | +when it's added, so be cautious about its use, particularly in tests of the I/O | 349 | 349 | and streaming APIs. | 350 | 350 |
| 351 | 351 | Excessive use of console output is discouraged as it can overwhelm the display, | |
|