GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: settle pending broadcast reads on return · nodejs/node@fbed90b

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/streams/iter
- broadcast.js
test/parallel
- test-stream-iter-broadcast-basic.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/streams/iter/broadcast.js‎`

Copy file name to clipboardExpand all lines: lib/internal/streams/iter/broadcast.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,7 @@ class BroadcastImpl {`
`165`	`165`
`166`	`166`	`function detach() {`
`167`	`167`	`state.detached = true;`
	`168`	`+ state.resolve?.({ __proto__: null, done: true, value: undefined });`
`168`	`169`	`state.resolve = null;`
`169`	`170`	`state.reject = null;`
`170`	`171`	`if (self.#deleteConsumer(state)) {`

Collapse file

`‎test/parallel/test-stream-iter-broadcast-basic.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-stream-iter-broadcast-basic.js

+13Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,18 @@ async function testCancelWithReason() {`
`161`	`161`	`assert.strictEqual(result.message, 'cancelled');`
`162`	`162`	`}`
`163`	`163`
	`164`	`+async function testPendingNextSettlesAfterReturn() {`
	`165`	`+ const { broadcast: bc } = broadcast();`
	`166`	`+ const iter = bc.push()[Symbol.asyncIterator]();`
	`167`	`+`
	`168`	`+ const pendingNext = iter.next();`
	`169`	`+ await iter.return();`
	`170`	`+`
	`171`	`+ const result = await pendingNext;`
	`172`	`+ assert.strictEqual(result.done, true);`
	`173`	`+ assert.strictEqual(result.value, undefined);`
	`174`	`+}`
	`175`	`+`
`164`	`176`	`// =============================================================================`
`165`	`177`	`// Writer fail detaches consumers`
`166`	`178`	`// =============================================================================`
`@@ -254,6 +266,7 @@ Promise.all([`
`254`	`266`	`testCancelWithoutReason(),`
`255`	`267`	`testCancelWithReason(),`
`256`	`268`	`testCancelWithFalsyReason(),`
	`269`	`+ testPendingNextSettlesAfterReturn(),`
`257`	`270`	`testFailDetachesConsumers(),`
`258`	`271`	`testWriterFailIdempotent(),`
`259`	`272`	`testLateJoinerSeesBufferedData(),`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.