GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: revise CI text in collaborator guide · nodejs/node@fdc6a96

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/guides
- collaborator-guide.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/guides/collaborator-guide.md‎`

Copy file name to clipboardExpand all lines: doc/guides/collaborator-guide.md

+6-6Lines changed: 6 additions & 6 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -210,11 +210,11 @@ the comment anyway to avoid any doubt.`
`210`	`210`	`All fixes must have a test case which demonstrates the defect. The test should`
`211`	`211`	`fail before the change, and pass after the change.`
`212`	`212`
`213`		`-Do not land any pull requests without a passing (green or yellow) CI run.`
`214`		`-A green GitHub Actions CI result is required. A passing`
`215`		`-[Jenkins CI](https://ci.nodejs.org/) is also required if PR contains changes`
`216`		-that will affect the `node` binary. This is critical as GitHub Actions CI does
`217`		`-not cover all the environments supported by Node.js.`
	`213`	`+Do not land any pull requests without the necessary passing CI runs.`
	`214`	`+A passing (green) GitHub Actions CI result is required. A passing (green or`
	`215`	`+yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull`
	`216`	+request contains changes that will affect the `node` binary. This is because
	`217`	`+GitHub Actions CI does not cover all the environments supported by Node.js.`
`218`	`218`
`219`	`219`	`<details>`
`220`	`220`	<summary>Changes that affect the `node` binary</summary>
`@@ -295,7 +295,7 @@ in the form:`
`295`	`295`	To specify the branch this way, `refs/heads/BRANCH` is used
`296`	`296`	(e.g. for `master` -> `refs/heads/master`).
`297`	`297`	For pull requests, it will look like `refs/pull/PR_NUMBER/head`
`298`		-(e.g. for PR#42 -> `refs/pull/42/head`).
	`298`	+(e.g. for pull request #42 -> `refs/pull/42/head`).
`299`	`299`	* `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased
`300`	`300`	`onto master. This can especially be important for pull requests that have been`
`301`	`301`	`open a while.`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.