GeezerVison is showing github.com — doc: revise accepting-modifications in guide · nodejs/node@fe698d8
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md +4-6Lines changed: 4 additions & 6 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -93,12 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the |
93 | 93 |
|
94 | 94 | ## Accepting Modifications |
95 | 95 |
|
96 | | -All modifications to the Node.js code and documentation should be performed via |
97 | | -GitHub pull requests, including modifications by Collaborators and TSC members. |
98 | | -A pull request must be reviewed, and must also be tested with CI, before being |
99 | | -landed into the codebase. There may be exceptions to the latter (the changed |
100 | | -code cannot be tested with a CI or similar). If that is the case, please leave a |
101 | | -comment that explains why the PR does not require a CI run. |
| 96 | +Contributors propose modifications to Node.js using GitHub pull requests. This |
| 97 | +is true for all modifications including those proposed by TSC members and other |
| 98 | +Collaborators. A pull request must pass code review and CI before landing into |
| 99 | +the codebase. |
102 | 100 |
|
103 | 101 | ### Code Reviews |
104 | 102 |
|
|