GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: V8: cherry-pick 1a391f98cc7a · nodejs/node@feefd17

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

common.gypi
deps/v8
- include
  - v8-promise.h
- src
  - d8
    - d8.cc
  - runtime
    - runtime-promise.cc
- test
  - cctest
    - test-api.cc
  - inspector
    - isolate-data.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎common.gypi‎`

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@`
`41`	`41`
`42`	`42`	`# Reset this number to 0 on major V8 upgrades.`
`43`	`43`	`# Increment by one for each non-official patch applied to deps/v8.`
`44`		`- 'v8_embedder_string': '-node.21',`
	`44`	`+ 'v8_embedder_string': '-node.22',`
`45`	`45`
`46`	`46`	`##### V8 defaults for Node.js #####`
`47`	`47`

Collapse file

`‎deps/v8/include/v8-promise.h‎`

Copy file name to clipboardExpand all lines: deps/v8/include/v8-promise.h

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -158,8 +158,10 @@ using PromiseHook = void (*)(PromiseHookType type, Local<Promise> promise,`
`158`	`158`	`enum PromiseRejectEvent {`
`159`	`159`	`kPromiseRejectWithNoHandler = 0,`
`160`	`160`	`kPromiseHandlerAddedAfterReject = 1,`
`161`		`- kPromiseRejectAfterResolved = 2,`
`162`		`- kPromiseResolveAfterResolved = 3,`
	`161`	`+ kPromiseRejectAfterResolved V8_DEPRECATED("These events are being removed") =`
	`162`	`+ 2,`
	`163`	`+ kPromiseResolveAfterResolved V8_DEPRECATED("These events are being removed") =`
	`164`	`+ 3,`
`163`	`165`	`};`
`164`	`166`
`165`	`167`	`class PromiseRejectMessage {`

Collapse file

`‎deps/v8/src/d8/d8.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/d8/d8.cc

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4575,11 +4575,13 @@ static void PrintMessageCallback(Local<Message> message, Local<Value> error) {`
`4575`	`4575`
`4576`	`4576`	`void Shell::PromiseRejectCallback(v8::PromiseRejectMessage data) {`
`4577`	`4577`	`if (options.ignore_unhandled_promises) return;`
	`4578`	`+ START_ALLOW_USE_DEPRECATED();`
`4578`	`4579`	`if (data.GetEvent() == v8::kPromiseRejectAfterResolved \|\|`
`4579`	`4580`	`data.GetEvent() == v8::kPromiseResolveAfterResolved) {`
`4580`	`4581`	`// Ignore reject/resolve after resolved.`
`4581`	`4582`	`return;`
`4582`	`4583`	`}`
	`4584`	`+ END_ALLOW_USE_DEPRECATED();`
`4583`	`4585`	`v8::Local<v8::Promise> promise = data.GetPromise();`
`4584`	`4586`	`v8::Isolate* isolate = v8::Isolate::GetCurrent();`
`4585`	`4587`	`PerIsolateData* isolate_data = PerIsolateData::Get(isolate);`

Collapse file

`‎deps/v8/src/runtime/runtime-promise.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/runtime/runtime-promise.cc

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,10 @@ RUNTIME_FUNCTION(Runtime_PromiseRejectAfterResolved) {`
`34`	`34`	`HandleScope scope(isolate);`
`35`	`35`	`DirectHandle<JSPromise> promise = args.at<JSPromise>(0);`
`36`	`36`	`DirectHandle<Object> reason = args.at(1);`
	`37`	`+ START_ALLOW_USE_DEPRECATED();`
`37`	`38`	`isolate->ReportPromiseReject(promise, reason,`
`38`	`39`	`v8::kPromiseRejectAfterResolved);`
	`40`	`+ END_ALLOW_USE_DEPRECATED();`
`39`	`41`	`return ReadOnlyRoots(isolate).undefined_value();`
`40`	`42`	`}`
`41`	`43`
`@@ -44,8 +46,10 @@ RUNTIME_FUNCTION(Runtime_PromiseResolveAfterResolved) {`
`44`	`46`	`HandleScope scope(isolate);`
`45`	`47`	`DirectHandle<JSPromise> promise = args.at<JSPromise>(0);`
`46`	`48`	`DirectHandle<Object> resolution = args.at(1);`
	`49`	`+ START_ALLOW_USE_DEPRECATED();`
`47`	`50`	`isolate->ReportPromiseReject(promise, resolution,`
`48`	`51`	`v8::kPromiseResolveAfterResolved);`
	`52`	`+ END_ALLOW_USE_DEPRECATED();`
`49`	`53`	`return ReadOnlyRoots(isolate).undefined_value();`
`50`	`54`	`}`
`51`	`55`

Collapse file

`‎deps/v8/test/cctest/test-api.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/test/cctest/test-api.cc

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16438,6 +16438,7 @@ void PromiseRejectCallback(v8::PromiseRejectMessage reject_message) {`
`16438`	`16438`	`CHECK(reject_message.GetValue().IsEmpty());`
`16439`	`16439`	`break;`
`16440`	`16440`	`}`
	`16441`	`+ START_ALLOW_USE_DEPRECATED();`
`16441`	`16442`	`case v8::kPromiseRejectAfterResolved: {`
`16442`	`16443`	`promise_reject_after_resolved_counter++;`
`16443`	`16444`	`break;`
`@@ -16446,6 +16447,7 @@ void PromiseRejectCallback(v8::PromiseRejectMessage reject_message) {`
`16446`	`16447`	`promise_resolve_after_resolved_counter++;`
`16447`	`16448`	`break;`
`16448`	`16449`	`}`
	`16450`	`+ END_ALLOW_USE_DEPRECATED();`
`16449`	`16451`	`}`
`16450`	`16452`	`}`
`16451`	`16453`

Collapse file

`‎deps/v8/test/inspector/isolate-data.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/test/inspector/isolate-data.cc

+9-4Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -401,10 +401,15 @@ void InspectorIsolateData::PromiseRejectHandler(v8::PromiseRejectMessage data) {`
`401`	`401`	`v8_inspector::StringView(reinterpret_cast<const uint8_t*>(reason_str),`
`402`	`402`	`strlen(reason_str)));`
`403`	`403`	`return;`
`404`		`- } else if (data.GetEvent() == v8::kPromiseRejectAfterResolved \|\|`
`405`		`- data.GetEvent() == v8::kPromiseResolveAfterResolved) {`
`406`		`- // Ignore reject/resolve after resolved, like the blink handler.`
`407`		`- return;`
	`404`	`+`
	`405`	`+ } else {`
	`406`	`+ START_ALLOW_USE_DEPRECATED();`
	`407`	`+ if (data.GetEvent() == v8::kPromiseRejectAfterResolved \|\|`
	`408`	`+ data.GetEvent() == v8::kPromiseResolveAfterResolved) {`
	`409`	`+ // Ignore reject/resolve after resolved, like the blink handler.`
	`410`	`+ return;`
	`411`	`+ }`
	`412`	`+ END_ALLOW_USE_DEPRECATED();`
`408`	`413`	`}`
`409`	`414`
`410`	`415`	`v8::Local<v8::Value> exception = data.GetValue();`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.