Description

Apollon77

opened on May 9, 2022

Issue body actions

Version

18.x

Platform

any

Subsystem

dns?

What steps will reproduce the bug?

see #41431 (review)

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

The family is backward compatible a string and not an integer thatbreaks many modules

What do you see instead?

family is an integer breaking many libraries

Additional information

Please see the comments in the linked PR and consider a "fix" fo this breaking change

Reacted by Ingo Fischer, Sören Beye, yeliex, Joe, Moritz Heusinger, Christoph Gerle, fastfoot, Peter Müller, AlCalzone, Achim Königs and 4 more

Activity

1. Apollon77

   changed the title [-]Revert the change of network interfaces family from Striung to Integer[/-] [+]Revert the change of network interfaces family from String to Integer[/+] on May 9, 2022
2. joe-hilling commented on May 9, 2022

   

   joe-hilling

   on May 9, 2022

   More actions

   Seeing a lot a pain coming out of this breaking change.
3. richardlau commented on May 9, 2022

   

   richardlau

   on May 9, 2022

   Member

   More actions

   cc @nodejs/tsc I think I'd lean towards reverting #41431, even though reverting the change would itself be breaking. Or at least restoring the family attribute on network interface objects to a string.

   Reacted by Ingo Fischer and Darshan Sen
4. Trott

   added

   tsc-agendaIssues and PRs to discuss during Technical Steering Committee meetings.Issues and PRs to discuss during Technical Steering Committee meetings.

   on May 9, 2022
5. Trott commented on May 9, 2022

   

   Trott

   on May 9, 2022

   Member

   More actions

   cc @nodejs/tsc I think I'd lean towards reverting #41431, even though reverting the change would itself be breaking. Or at least restoring the family attribute on network interface objects to a string.

   I tentatively agree.

   @aduh95 @mcollina
6. BethGriggs commented on May 9, 2022

   

   BethGriggs

   on May 9, 2022

   Member

   More actions

   Agree, this change has been more disruptive than I think we'd have liked. I'd be +1 on a revert.

   I have seen that some of the ecosystem has already spent time investigating and adjusting to this change. Would a full revert cause additional disruption at this point? I'm curious if there's a way to adequately mitigate the impact of the change without causing further disruption. Would the suggestions in #41431 (comment) be sufficient?
7. Apollon77 commented on May 9, 2022

   

   Apollon77

   on May 9, 2022

   Author

   More actions

   I assume (at least from the changes I have "seen" and because of needed nodejs backward compatibility) most simply added it as alternative to support both variants ... So a revert should (!) for most just lead to a "dead code OR clause"

   Reacted by Beth Griggs and Tobias Nießen
8. VoltrexKeyva

   added

   dnsIssues and PRs related to the dns subsystem.Issues and PRs related to the dns subsystem.

   on May 9, 2022
9. Apollon77 commented on May 22, 2022

   

   Apollon77

   on May 22, 2022

   Author

   More actions

   Inthe TSC meeting (at least as I understand the minutes) it was decided to revert the "integrater family back to Strings" ... should be in Node.js 18.2. Thank you very much for this!

   Reacted by Jan Romann and yeliex
10. 7 remaining items
11. nodejs-github-bot

    added a commit that references this issue on Aug 3, 2022

    net, dns: socket should handle its output as input

    ddd9c70
12. danielleadams

    added a commit that references this issue on Aug 16, 2022

    net, dns: socket should handle its output as input

    e6a47e8
13. ruyadorno

    added a commit that references this issue on Aug 23, 2022

    net, dns: socket should handle its output as input

    c3d8756
14. juanarbol

    added 2 commits that reference this issue on Oct 3, 2022

    net, dns: socket should handle its output as input

    c3a89ff

    net, dns: socket should handle its output as input

    9bd3fae
15. isheludko

    added a commit that references this issue on Mar 21, 2024

    dns: accept `'IPv4'` and `'IPv6'` for `family`

    70b516e
16. nrako

    added 7 commits that reference this issue on Nov 30, 2025

    fix(node/net): return string `family` in `server.address()`

    ebd08d6

    fix(node/net): return string `family` in `server.address()`

    618980d

    fix(node/net): return string `family` in `server.address()`

    6ba8a42

    fix(node/net): return string `family` in `server.address()`

    b7c45b3

    fix(node/net): return string `family` in `server.address()`

    fd3260a

    fix(node/net): return string `family` in `server.address()`

    7fe7995

    fix(node/net): return string `family` in `server.address()`

    6911007
17. Tango992

    added a commit that references this issue on Dec 6, 2025

    fix(node/net): return string `family` in `server.address()` (#31465)

    bc9d356

Issue actions