GeezerVison is showing github.com — lib: fix worker threads can't read stdout by leeight · Pull Request #24652 · nodejs/node
Conversation
leeight
commented
Nov 26, 2018
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fix: #24636
Checklist
-
make -j4 test (UNIX), or vcbuild test (Windows) passes
- tests and/or benchmarks are included
- commit message follows commit guidelines
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
if (err) throw err
^
Error: Invalid api format
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
at IncomingMessage.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1098:12)
at process.internalTickCallback (internal/process/next_tick.js:72:19)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@leeight Thank you! Can you explain why this fixes the issue, and add a regression test?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
if (err) throw err
^
Error: Invalid api format
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
at IncomingMessage.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1098:12)
at process.internalTickCallback (internal/process/next_tick.js:72:19)
I think this is a different manifestation of hitting the GitHub API rate limit (#24567) within core-validate-commit rather than before calling it. It should be addressed by #24574 which will avoid calling the GitHub API.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I think this has been resolved by #24932? Either way, thank you for the PR! 👍
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
worker
Issues and PRs related to the worker_threads module and Worker API.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Worker Threads can't read stdout
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.