GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: check inspector command Debugger.setInstrumentationBreakpoint by ulitink · Pull Request #31137 · nodejs/node

Conversation

ulitink commented Dec 30, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Adds test case for inspector's method Debugger.setInstrumentationBreakpoint with beforeScriptExecution param.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label

Dec 30, 2019

ulitink mentioned this pull request

Dec 30, 2019

Debugger.setInstrumentationBreakpoint is broken #31138

Open

addaleax added the inspector Issues and PRs related to the V8 inspector protocol. label

Dec 30, 2019

BridgeAR commented Jan 4, 2020

Copy link

Copy Markdown

Member

@ulitink is this ready to review? Or is this still work in progress?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ulitink commented Jan 5, 2020

Copy link

Copy Markdown

Contributor Author

@BridgeAR It is a test for an issue #31138. We can't merge this pull request until the issue is fixed because the test is broken. Sorry if such workflow is bad, we can simply reject the pull request and wait for the issue to be fixed, test is still referenced from it and can be found.

BridgeAR reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR commented Jan 6, 2020

Copy link

Copy Markdown

Member

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott commented Jan 6, 2020

Copy link

Copy Markdown

Member

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

If the test fails 100% of the time, probably best to put it in known_issues and then we can move it out to parallel (or wherever) when the fix is committed.

ulitink reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ulitink marked this pull request as ready for review

January 11, 2020 03:05

BridgeAR approved these changes

Jan 11, 2020

View reviewed changes

BridgeAR left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Jan 11, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28379/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Jan 12, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28406/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott reviewed

Jan 14, 2020

View reviewed changes

Comment thread

test/fixtures/inspector-instrumentation-breakpoint/main.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Trott commented Jan 14, 2020

Copy link

Copy Markdown

Member

@nodejs/inspector

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott approved these changes

Jan 14, 2020

View reviewed changes

Trott reviewed

Jan 14, 2020

View reviewed changes

Comment thread

test/known_issues/test-inspector-instrumentation-breakpoint.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare

May 31, 2020 12:19

gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 5, 2020

gireeshpunathil commented Nov 5, 2020

Copy link

Copy Markdown

Member

Is this ready to land?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 5, 2020

This comment has been minimized.

nodejs-github-bot commented Nov 8, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34211/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare

March 29, 2021 21:33

nodejs-github-bot commented Sep 18, 2023

larson-carter commented Apr 17, 2024

Copy link

Copy Markdown

Member

This is a quite old PR, I see it ties into #31138 is there any updates?

Soarex16 reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 3, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58895/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes

May 4, 2024

View reviewed changes

nodejs-github-bot commented May 10, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59079/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 reviewed

May 11, 2024

View reviewed changes

Comment thread

test/known_issues/test-inspector-instrumentation-breakpoint.js Outdated

aduh95 May 11, 2024

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like skipping makes the test succeeds, which is considered a failure for known_issues/ tests..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ulitink and others added 6 commits

May 11, 2024 10:09


          test: add Debugger.setInstrumentationBreakpoint known issue


          test: mute test-inspector-instrumentation-breakpoint

6a74aa6


          test: fix formatting in test-inspector-instrumentation-breakpoint

38aa857


          test: add description, fix linters

833be9c


          lint

9c8a452


          better skip

29607a1

aduh95 commented May 12, 2024

Copy link

Copy Markdown

Contributor

Landed in 291c121

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos mentioned this pull request

May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request

Jun 17, 2024

v20.15.0 proposal #53486

Merged

Reviewers

Trott

Trott approved these changes

aduh95

aduh95 left review comments

jasnell

jasnell approved these changes

BridgeAR

BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

inspector

Issues and PRs related to the V8 inspector protocol.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ulitink commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

BridgeAR commented Jan 4, 2020

Uh oh!

ulitink commented Jan 5, 2020

Uh oh!

BridgeAR commented Jan 6, 2020

Uh oh!

Trott commented Jan 6, 2020

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 11, 2020

Uh oh!

nodejs-github-bot commented Jan 12, 2020

Uh oh!

Uh oh!

Trott commented Jan 14, 2020

Uh oh!

Uh oh!

gireeshpunathil commented Nov 5, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Nov 8, 2020

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Oct 6, 2023

Uh oh!

nodejs-github-bot commented Oct 15, 2023

Uh oh!

nodejs-github-bot commented Nov 11, 2023

Uh oh!

larson-carter commented Apr 17, 2024

Uh oh!

nodejs-github-bot commented May 3, 2024

Uh oh!

nodejs-github-bot commented May 10, 2024

Uh oh!

aduh95 May 11, 2024

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 11, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

aduh95 commented May 12, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ulitink commented Dec 30, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.