GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v12.x] deps: V8: cherry-pick d89f4ef1cd62 by miladfarca · Pull Request #31344 · nodejs/node

Conversation

@miladfarca

@miladfarca miladfarca commented Jan 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Original commit message:

S390x: improve performance by skipping Debug Hook if not needed

Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
Reviewed-by: Junliang Yan <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Milad Farazmand
deps: V8: cherry-pick d89f4ef1cd62
69c230b 
Original commit message:

    S390x: improve performance by skipping Debug Hook if not needed

    Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 13, 2020
@miladfarca

miladfarca commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/platform-s390
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jan 13, 2020
View reviewed changes
sam-github
sam-github approved these changes Jan 13, 2020
View reviewed changes
BethGriggs
BethGriggs approved these changes Jan 13, 2020
View reviewed changes
mhdawson
mhdawson approved these changes Jan 13, 2020
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau richardlau changed the title deps: V8: cherry-pick d89f4ef1cd62 [12.x] deps: V8: cherry-pick d89f4ef1cd62 Jan 13, 2020
@richardlau richardlau changed the title [12.x] deps: V8: cherry-pick d89f4ef1cd62 [v12.x] deps: V8: cherry-pick d89f4ef1cd62 Jan 13, 2020
@targos

targos commented Jan 14, 2020

Copy link
Copy Markdown
Member

Is this not needed on master/v13.x ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miladfarca

miladfarca commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@targos I'm trying to back-port it to Node 12, if you think it needs to be on other branches I can make separate PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 14, 2020

Copy link
Copy Markdown
Member

@miladfarca We usually do it the other way: PR to master, then cherry-pick (or open a backport PR if needed) to release branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miladfarca

miladfarca commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@targos here is a PR to master: #31354
Let me know if it needs to be ported to other branches as well.
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request Jan 14, 2020
deps: V8: cherry-pick d89f4ef1cd62 #31354
Closed
2 tasks done
@targos
targos force-pushed the v12.x-staging branch from eb4b47f to 8252c06 Compare January 14, 2020 15:58
@targos

targos commented Jan 15, 2020

Copy link
Copy Markdown
Member

cherry-picked #31354 on v12.x-staging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+2 more reviewers
@sam-github sam-github sam-github approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@miladfarca @targos @sam-github @richardlau @BethGriggs @mhdawson @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.