GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — quic: part 2... ngtcp2 and nghttp3 by jasnell · Pull Request #32378 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the second of three separate PRs that would need to be landed together. They have been split to allow easier reviewing. This PR covers the addition of the ngtcp2 and nghttp3 dependencies to the source tree.

NOTE: This PR merges into the initial-quic-part-1 branch

The other two PRs in this batch are:

  • openssl modifications: quic: part 1... quic-modified openssl #32377
  • quic implementation: quic: part 3... initial quic implementation #32379
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
This was referenced Mar 19, 2020
quic: part 3... initial quic implementation #32379
Closed
quic: part 1... quic-modified openssl #32377
Closed
quic: initial experimental quic implementation #30943
Closed
@jasnell
jasnell requested review from addaleax and sam-github March 19, 2020 22:35
@sam-github

sam-github commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

This commit has two .gyp files in it, which are unique to Node.js (and have inconsistent indentation, if that matters).

For maintainability, the commit adding the gyp files that we maintain should be split from the commit adding the upstream maintained source.

The commit adding the upstream src should describe where it came from, and what version of the dep got vendored in (probably just a "curled from this URL (that includes a version), untarred, moved into place" is sufficient if it came from a released tarball.

There should be commit adding a doc/guide/maintaining-ngXXX doc (one? two? as you think reasonable) that describes how to update these deps when they inevitably need updating.

jasnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell

jasnell commented Mar 20, 2020

Copy link
Copy Markdown
Member Author

Will work those changes in @sam-github thank you :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell
jasnell force-pushed the initial-quic-part-1 branch from 718a2b7 to 00bfcd9 Compare March 24, 2020 01:15
@jasnell
jasnell force-pushed the initial-quic-part-2 branch from ae9efc1 to c6cc7d0 Compare March 24, 2020 01:15
@jasnell

jasnell commented Mar 24, 2020

Copy link
Copy Markdown
Member Author

Updated to include maintenance instructions

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell added the review wanted PRs that need review. label Mar 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30290/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell

jasnell commented Mar 31, 2020

Copy link
Copy Markdown
Member Author

Putting all three of the PRs here on the tsc-agenda to queue up discussion on how we want to get these landed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell added tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. quic Issues and PRs related to the QUIC transport implementation. labels Mar 31, 2020
This was referenced Apr 6, 2020
Node.js Technical Steering Committee (TSC) Meeting 2020-04-08 nodejs/TSC#846
Closed
Node.js Technical Steering Committee (TSC) Meeting 2020-04-16 nodejs/TSC#848
Closed
@jasnell jasnell removed the tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. label Apr 15, 2020
@jasnell
jasnell force-pushed the initial-quic-part-1 branch from 00bfcd9 to 7afa9a8 Compare May 7, 2020 23:44
@jasnell
jasnell force-pushed the initial-quic-part-2 branch from c6cc7d0 to 88ea645 Compare May 7, 2020 23:45
@jasnell

jasnell commented May 7, 2020

Copy link
Copy Markdown
Member Author

nodejs/quic master was rebased and sync'd with nodejs/master earlier today. The commits in the PR have been updated accordingly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell
jasnell force-pushed the initial-quic-part-1 branch from 7afa9a8 to 846b216 Compare June 3, 2020 23:35
@jasnell
jasnell force-pushed the initial-quic-part-2 branch from 88ea645 to 28fbb81 Compare June 3, 2020 23:36
Qard
Qard approved these changes Jun 4, 2020
View reviewed changes
@jasnell
jasnell force-pushed the initial-quic-part-1 branch from 846b216 to 0612442 Compare June 9, 2020 16:22
@jasnell
jasnell force-pushed the initial-quic-part-2 branch from 28fbb81 to 9f13c4f Compare June 9, 2020 16:22
@jasnell
jasnell force-pushed the initial-quic-part-1 branch from 0612442 to e96bea6 Compare June 16, 2020 16:14
jasnell added 2 commits June 16, 2020 09:15
@jasnell
deps: add ngtcp2 and nghttp3
6c6ba3c
Signed-off-by: James M Snell <[email protected]>
@jasnell
deps: maintaining ngtcp2 and nghttp3
813739b
Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the initial-quic-part-2 branch from 9f13c4f to 813739b Compare June 16, 2020 16:15
@jasnell jasnell closed this Jun 16, 2020
@codebytere codebytere added backport-requested-v14.x and removed backport-requested-v14.x labels Jun 18, 2020
@devsnek
devsnek deleted the initial-quic-part-2 branch August 31, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@addaleax addaleax Awaiting requested review from addaleax
@sam-github sam-github Awaiting requested review from sam-github

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

quic Issues and PRs related to the QUIC transport implementation. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @sam-github @nodejs-github-bot @Qard @codebytere
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.