GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — quic: part 2... ngtcp2 and nghttp3 by jasnell · Pull Request #32378 · nodejs/node Conversation
|
|
This commit has two .gyp files in it, which are unique to Node.js (and have inconsistent indentation, if that matters). For maintainability, the commit adding the gyp files that we maintain should be split from the commit adding the upstream maintained source. The commit adding the upstream src should describe where it came from, and what version of the dep got vendored in (probably just a "curled from this URL (that includes a version), untarred, moved into place" is sufficient if it came from a released tarball. There should be commit adding a doc/guide/maintaining-ngXXX doc (one? two? as you think reasonable) that describes how to update these deps when they inevitably need updating. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Will work those changes in @sam-github thank you :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
718a2b7 to
00bfcd9
Compare
ae9efc1 to
c6cc7d0
Compare
|
Updated to include maintenance instructions |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Putting all three of the PRs here on the tsc-agenda to queue up discussion on how we want to get these landed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
00bfcd9 to
7afa9a8
Compare
c6cc7d0 to
88ea645
Compare
|
nodejs/quic master was rebased and sync'd with nodejs/master earlier today. The commits in the PR have been updated accordingly. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
7afa9a8 to
846b216
Compare
88ea645 to
28fbb81
Compare
846b216 to
0612442
Compare
28fbb81 to
9f13c4f
Compare
0612442 to
e96bea6
Compare
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
9f13c4f to
813739b
Compare
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.