GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — esm: merge and simplify loader hooks by hybrist · Pull Request #35524 · nodejs/node

Conversation

@hybrist

@hybrist hybrist commented Oct 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Demo for reducing the number of hooks and allowing more delegation to the builtin hooks.

Downsides:

  • Eagerly loads source for JSON, even when it's not used.
  • If node thinks a module is CommonJS, it will currently not return the source from getSource. Since we now parse the CommonJS source for named exports, it would likely be fine if we'd return source from load anyhow but it's unclear how that would interact with userland hooks.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, lin7sh, and Maxusz666 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@hybrist
esm: merge and simplify loader hooks
52fc651
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 6, 2020
@GeoffreyBooth

GeoffreyBooth commented Oct 8, 2020

Copy link
Copy Markdown
Member

I’ve been looking into trying to implement loader chaining, where each user loader can modify the return value of the previous one(s), for all hooks. I think we need to merge the getFormat and getSource hooks to accomplish chaining, too, not just to solve #34144, so this PR would be a prerequisite for a chaining PR. I’ll try to find time soon to finish this up and get all the tests passing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 21, 2020
Node.js Modules Team Meeting 2020-10-07 nodejs/modules#557
Closed
@hybrist hybrist mentioned this pull request Nov 30, 2020
Https imports #36328
Merged
8 of 9 tasks
This was referenced Dec 4, 2020
Public API for compilers denoland/deno#1739
Closed
module: ESM loaders next steps #36396
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Feb 21, 2021
esm: consolidate ESM Loader methods #37468
Closed
3 tasks done
@guybedford
guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33
@GeoffreyBooth

GeoffreyBooth commented Sep 12, 2021

Copy link
Copy Markdown
Member

Completed by #37468
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth closed this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hybrist @nodejs-github-bot @GeoffreyBooth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.