GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Documentation for how to unref readline by vbinithyanandamv · Pull Request #36458 · nodejs/node

Conversation

@vbinithyanandamv

@vbinithyanandamv vbinithyanandamv commented Dec 9, 2020

Copy link
Copy Markdown

#36154

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
szmarczak, bricss, and vbinithyanandamv reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@vbinithyanandamv
Documentation for how to unref readline
74fff9d 
nodejs#36154
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. readline Issues and PRs related to the built-in readline module. labels Dec 9, 2020
@vbinithyanandamv
Update readline.md
5e916fd 
Removed tab character and added 2 space
aduh95
aduh95 approved these changes Dec 29, 2020
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. One minor nit:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/readline.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vbinithyanandamv @aduh95
Update doc/api/readline.md
e3a7bc7 
As per suggestion.

Co-authored-by: Antoine du Hamel <[email protected]>
@vbinithyanandamv

vbinithyanandamv commented Dec 30, 2020

Copy link
Copy Markdown
Author

Thanks for doing this. One minor nit:

@aduh95 updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Reading through the readline docs, it seems this example may be lacking context. Could you add a sentence explaining the use-case and when it is useful?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 9, 2021

Copy link
Copy Markdown
Member

Welcome, @vbinithyanandamv and thanks for the pull request. I'm not sure this warrants its own section. Seems like it should go in the section of whatever call might result in requiring the unref() call. It would be good to incorporate it into an existing section, I think.
jasnell and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

@vbinithyanandamv Are you still planing on working on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vbinithyanandamv

vbinithyanandamv commented Feb 19, 2021

Copy link
Copy Markdown
Author

@vbinithyanandamv Are you still planing on working on this?

@vbinithyanandamv not any soon, you can take it up if you want to work on it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. labels Feb 19, 2021
@github-actions

github-actions Bot commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Mar 27, 2021
@AnupamaP AnupamaP mentioned this pull request Apr 1, 2021
doc: add unref for input in readline #38019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. readline Issues and PRs related to the built-in readline module. stalled Issues and PRs manually marked as stalled and scheduled for automatic closure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vbinithyanandamv @aduh95 @Trott @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.