GeezerVison is showing github.com — fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown by ycjcl868 · Pull Request #37997 · nodejs/node
Conversation
ycjcl868
commented
Mar 31, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes: #37995
Uint32 should be between [0, 2 ** 32)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss and ycjcl868 reacted with thumbs up emoji
RaisinTen
commented
Mar 31, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I'm not sure that this is a valid fix for this issue as -1 is actually an accepted value for owner and group. This is almost like a revert of #31694 which added support for -1.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ycjcl868
changed the title
fix: valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown
fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown
Apr 1, 2021
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
"fs.chownSync" results in an abort
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.