GeezerVison is showing github.com — test: mark sequential/test-gc-http-client-onerror as flaky by mcollina · Pull Request #43957 · nodejs/node
Conversation
mcollina
commented
Jul 23, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mcollina
added
request-ci
Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.
and removed
test
Issues and PRs related to Node.js core tests and test infrastructure.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sequential/test-gc-http-client is also flaky (just like sequential/test-gc-http-client-timeout).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Definitely. sequential/test-gc-http-client failed 7 times yesterday like this one.
I opened a PR at a time as it seems how it was done other times, but I'm also ok in massively adding all of them in one.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It looks like the issue will be fixed by #43949.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
FYI, #43949 has merged to main branch and fixed test-gc-http-client-onerror test. So this pr could be closed.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 25, 2022
Reviewers
tniessen
tniessen approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.