GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — net: add autoSelectFamily option by ShogunPanda · Pull Request #44731 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
5a35dae to
8e79310
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test for HTTPs too?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
8e79310 to
c301ed9
Compare
|
@nodejs/tsc this is a notable change that we should land before v18 goes LTS. We have seen quite a few reports of bugs due to improper configuration of IPv6, making #41625 a necessity. For example, Docker on Mac only exposes ports on the IPv4 address, making all connections to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
No comment (yet at least) one way or the other on the implementation, but +1000 to implementing happy eyeballs in Node.js. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The two new tests fail for me (Linux x64) and also in GitHub actions. Details |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Acknowledged! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Same goes for me as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
617860b to
b1c7de5
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can we add test for dnsPromises.Resolver as well?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
@nodejs/tsc
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm going to rebase and force push to at least get the tarball job working. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b1c7de5 to
25f2336
Compare
My case is that we should make it enabled by default. This causes so many headaches to newbie developers that know little of IPv4 vs IPv6 and why localhost is two IPs. We should make this change before v18 goes LTS. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| [IPC]: #ipc-support | ||
| [Identifying paths for IPC connections]: #identifying-paths-for-ipc-connections | ||
| [RFC 8305]: https://www.rfc-editor.org/rfc/rfc8305.txt |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| [IPC]: #ipc-support | ||
| [Identifying paths for IPC connections]: #identifying-paths-for-ipc-connections | ||
| [RFC 8305]: https://www.rfc-editor.org/rfc/rfc8305.txt |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Happy Eyeballs support (address IPv6 issues in Node 17)
There was an error while loading. Please reload this page.