GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: restore IS_RELEASE to 0 by bengl · Pull Request #44758 · nodejs/node

Conversation

@bengl

@bengl bengl commented Sep 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was accidentally left in during the most recent security release process.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bengl
src: restore IS_RELEASE to 0
595a9bc
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 23, 2022
ruyadorno
ruyadorno approved these changes Sep 23, 2022
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Sep 23, 2022
View reviewed changes
@ruyadorno ruyadorno added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 23, 2022
@RafaelGSS RafaelGSS added dont-land-on-v14.x and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Sep 23, 2022
@bengl bengl added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 23, 2022
@github-actions

github-actions Bot commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.
tniessen and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @bengl. Please 👍 to approve.
ruyadorno, richardlau, RafaelGSS, bengl, BethGriggs, bricss, tniessen, Trott, MylesBorins, and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 10 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Sep 23, 2022
View reviewed changes
BethGriggs
BethGriggs approved these changes Sep 23, 2022
View reviewed changes
tniessen
tniessen approved these changes Sep 23, 2022
View reviewed changes
@tniessen tniessen mentioned this pull request Sep 23, 2022
test: change promises to async/await #44697
Merged
MylesBorins
MylesBorins approved these changes Sep 23, 2022
View reviewed changes
Trott
Trott approved these changes Sep 23, 2022
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2022
@MylesBorins

MylesBorins commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

I'd like to propose that we just land this and don't wait for CI since all the changes are a single bit flip that will itself unbreak CI
bnb and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2022
@tniessen

tniessen commented Sep 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

ASan failure is due to #44735. I restarted the job but it might not be worth waiting for.

Edit: second attempt also failed because of the same test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46730/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46733/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnb
bnb approved these changes Sep 23, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46739/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46740/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46741/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46742/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen

tniessen commented Sep 24, 2022

Copy link
Copy Markdown
Member

@nodejs/build It looks like CI runs into infra failures every time.

21:59:18 FATAL: Connection timed out
21:59:18 java.net.ConnectException: Connection timed out
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46744/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Sep 24, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46745/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46747/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46748/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen

tniessen commented Sep 24, 2022

Copy link
Copy Markdown
Member

We haven't had a successful Jenkins run on any PR since yesterday morning, see nodejs/build#3037.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46751/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 45f2258 into nodejs:main Sep 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in 45f2258
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon mentioned this pull request Sep 25, 2022
test: add extra tests for basename with ext option #44772
Merged
@github-actions github-actions Bot mentioned this pull request Sep 26, 2022
CI Reliability 2022-09-26 nodejs/reliability#385
Open
18 tasks
@daeyeon daeyeon mentioned this pull request Sep 26, 2022
fs: don't hard code name in validatePosition() #44767
Merged
@github-actions github-actions Bot mentioned this pull request Sep 27, 2022
CI Reliability 2022-09-27 nodejs/reliability#386
Open
1 of 14 tasks
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@bnb bnb bnb approved these changes
@Trott Trott Trott approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@MylesBorins MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@bengl @MylesBorins @tniessen @nodejs-github-bot @ruyadorno @bnb @Trott @richardlau @BethGriggs @aduh95 @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.