GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: align `@@toStringTag` with other Web Streams implementations by aduh95 · Pull Request #45136 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

None of the other implementations are using a getter, let's align.

Alternative to #45117.
Fixes: #45114

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and MrJithil reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@aduh95
stream: align @@toStringTag with other webstream implementations
5cc283f
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Oct 23, 2022
@aduh95 aduh95 mentioned this pull request Oct 23, 2022
stream: fix web streams have no Symbol.toStringTag #45117
Merged
@aduh95 aduh95 added dont-land-on-v14.x labels Oct 23, 2022
lpinca
lpinca approved these changes Oct 23, 2022
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47427/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 23, 2022
daeyeon
daeyeon approved these changes Oct 24, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 24, 2022
View reviewed changes
targos
targos approved these changes Oct 24, 2022
View reviewed changes
F3n67u
F3n67u approved these changes Oct 24, 2022
View reviewed changes
benjamingr
benjamingr approved these changes Oct 24, 2022
View reviewed changes
@aduh95

aduh95 commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

Supplanted by #45117
benjamingr reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 closed this Oct 26, 2022
@aduh95
aduh95 deleted the webstream-toStringTag branch October 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@daeyeon daeyeon daeyeon approved these changes
+2 more reviewers
@targos targos targos approved these changes
@F3n67u F3n67u F3n67u approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

web streams have no Symbol.toStringTag on their prototypes

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @nodejs-github-bot @jasnell @benjamingr @lpinca @targos @daeyeon @F3n67u
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.