GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x] lib: drop fetch experimental warning by Richienb · Pull Request #45628 · nodejs/node

Conversation

@Richienb

@Richienb Richienb commented Nov 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Backports #45287 by cherry-picking the commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
styfle and cproof reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@mcollina @Richienb
lib: drop fetch experimental warning
c71009d 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#45287
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v18.x labels Nov 26, 2022
styfle
styfle approved these changes Nov 28, 2022
View reviewed changes

@styfle styfle left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I also think the docs need to be updated since those still stay experimental here: https://nodejs.org/api/globals.html#fetch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Richienb

Richienb commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

I also think the docs need to be updated since those still stay experimental here: nodejs.org/api/globals.html#fetch

I believe this also applies to the verison this pr is based on too. I believe documentation updates are an upstream problem and should be done there first in the main branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@styfle

styfle commented Nov 30, 2022

Copy link
Copy Markdown
Member

Sounds good! I created a PR: #45684
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48753/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams

danielleadams commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

@Richienb this is already landing in v18.x in v18.13.0 (#46025). Can this be closed?
Richienb and styfle reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Richienb Richienb closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@styfle styfle styfle approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Richienb @styfle @nodejs-github-bot @danielleadams @mcollina
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.