GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] backport utf8 performance improvements by anonrig · Pull Request #45650 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Nov 27, 2022

Copy link
Copy Markdown
Member

This is my first backport. If the time is right, I'd like to backport UTF8 encoding performance improvements, so that LTS users can access to the performance boosts.

I'm trying to backport the following changes to the v18 release line:

  • util: improve TextDecoder performance #45294
  • util: improve text-decoder performance #45363
  • util: move validations for text decoder to c++ #45388
  • util: add fast path for utf8 encoding #45412

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v18.x labels Nov 27, 2022
@anonrig
anonrig force-pushed the backport-utf8-to-v18.x branch from 4ad6874 to c1fd005 Compare November 27, 2022 23:58
anonrig and others added 6 commits November 27, 2022 19:01
@anonrig
util: improve textdecoder decode performance
367d631 
PR-URL: nodejs#45294
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
benchmark: fix text-decoder benchmark
f5e3920 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
benchmark: add parameters to text-decoder benchmark
22e9f5b 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
util: improve text-decoder performance
26fbc98 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
util: improve text decoder performance
8dea4eb 
PR-URL: nodejs#45388
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig @addaleax
util: add fast path for utf8 encoding
d86c37f 
Co-authored-by: Anna Henningsen <[email protected]>
PR-URL: nodejs#45412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@anonrig
anonrig force-pushed the backport-utf8-to-v18.x branch from c1fd005 to d86c37f Compare November 28, 2022 00:03
@targos

targos commented Nov 28, 2022

Copy link
Copy Markdown
Member

I appreciate the effort, but v18.x is Active LTS, so all changes should automatically be backported to it by releasers. You can add the lts-watch-v18.x label to make sure it happens.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

Thanks @targos!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@anonrig @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.