GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 11.1 by targos · Pull Request #46445 · nodejs/node

Conversation

@targos

@targos targos commented Jan 31, 2023

Copy link
Copy Markdown
Member

Possibly easier to land than #46125

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and lin72h reacted with eyes emoji
All reactions
  • 👀 2 reactions
targos added 7 commits January 31, 2023 16:18
@targos
deps: update V8 to 11.1.277.3
ba4a780
@targos
build: reset embedder string to "-node.0"
d46459a
@targos
src: update NODE_MODULE_VERSION to 115
6c5f87f 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 11.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
9cdd2c5 
dllexport introduces issues when compiling with MSVC.
@targos
deps: silence irrelevant V8 warning
4848585 
PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
tools: update V8 gypfiles for 11.0
38f3283
@targos
tools: update V8 gypfiles for 11.1
1e078bc
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jan 31, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 31, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49283/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5151/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5151/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

V8 test failure on ppc64le and s390x:

/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8: RangeError: Array buffer allocation failed
  const xs = new Uint16Array(3775336418);
             ^
RangeError: Array buffer allocation failed
    at new ArrayBuffer (<anonymous>)
    at new Uint16Array (<anonymous>)
    at foo (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8:14)
    at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:12:1
Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/regress/regress-1320641.js --random-seed=-1674014384 --nohard-abort --testing-d8-test-runner --allow-natives-syntax

@nodejs/platform-ppc @nodejs/platform-s390
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

Windows 32-bit build failure:

17:03:48   setup-isolate-full.cc
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(346,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(60,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

@nodejs/platform-windows
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

There seems to be an issue with WASM on ARM:

https://ci.nodejs.org/job/node-test-binary-armv7l/4285/RUN_SUBSET=js,label=ubuntu2004-armv7l/testReport/junit/(root)/test/wpt_test_wasm_webapi/
https://ci.nodejs.org/job/node-test-commit-arm-debug/6049/nodes=ubuntu2004_debug-arm64/testReport/junit/(root)/test/parallel_test_wasm_web_api/

@nodejs/platform-arm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen

gengjiawen commented Feb 1, 2023

Copy link
Copy Markdown
Member

Windows 32-bit build failure:

17:03:48   setup-isolate-full.cc
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(346,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(60,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

@nodejs/platform-windows

Similar to #45230 (comment)

cc @StefanStojanovic
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

Oh right, I forgot that we already had this error in the past. Don't know how it came back, but based on a bisect with canary, it seems to come from https://chromium-review.googlesource.com/c/v8/v8/+/4138254
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There's also an issue with the coverage build:

[ RUN      ] InspectorSocketTest.HostIPv6NonRoutable
../test/cctest/test_inspector_socket.cc:323: Failure
Value of: (!expectation.read_expected)
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketTest.HostIPv6NonRoutable (5000 ms)

Edit: looks like it was a flake
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen

gengjiawen commented Feb 2, 2023

Copy link
Copy Markdown
Member

Oh right, I forgot that we already had this error in the past. Don't know how it came back, but based on a bisect with canary, it seems to come from chromium-review.googlesource.com/c/v8/v8/+/4138254

Is it possible v8 add a win32 CI ? or should we drop win 32bit too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen mentioned this pull request Feb 2, 2023
Should we drop support for 32 bit Windows? #42543
Closed
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5151/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Feb 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Is it possible v8 add a win32 CI ? or should we drop win 32bit too.

I don't believe it, they just did (opt-in)!

https://bugs.chromium.org/p/v8/issues/detail?id=8811
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 mentioned this pull request Feb 18, 2023
lib: update punycode to 2.3.0 #46719
Closed
@targos

targos commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

I'll open a new PR with 11.2 later today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Feb 24, 2023
@targos
targos deleted the v8-111 branch April 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@targos @nodejs-github-bot @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.