GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update nghttp2 to 1.52.0 by nodejs-github-bot · Pull Request #46773 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of nghttp2 to 1.52.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito and bricss reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@nodejs-github-bot
deps: update nghttp2 to 1.52.0
195b49d
@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label Feb 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added http2 Issues and PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Feb 22, 2023
@marco-ippolito marco-ippolito mentioned this pull request Feb 22, 2023
deps: update nghttp2 to 1.52.0 #46636
Merged
lpinca
lpinca approved these changes Feb 22, 2023
View reviewed changes

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/49897/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Feb 23, 2023
CI Reliability 2023-02-23 nodejs/reliability#504
Open
31 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/49904/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes Feb 23, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Feb 23, 2023
@github-actions github-actions Bot mentioned this pull request Feb 24, 2023
CI Reliability 2023-02-24 nodejs/reliability#505
Open
25 tasks
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/46773
✔  Done loading data for nodejs/node/pull/46773
----------------------------------- PR info ------------------------------------
Title      deps: update nghttp2 to 1.52.0 (#46773)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-nghttp2 -> nodejs:main
Labels     http2, dependencies
Commits    1
 - deps: update nghttp2 to 1.52.0
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/46773
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46773
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 22 Feb 2023 14:54:48 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46773#pullrequestreview-1310173009
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/46773#pullrequestreview-1310511169
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-02-23T01:17:51Z: https://ci.nodejs.org/job/node-test-pull-request/49904/
- Querying data for job/node-test-pull-request/49904/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46773
From https://github.com/nodejs/node
 * branch                  refs/pull/46773/merge -> FETCH_HEAD
✔  Fetched commits as 0c90be907211..195b49d2427a
--------------------------------------------------------------------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch main
Your branch is up to date with 'origin/main'.

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
labels.json
output

nothing added to commit but untracked files present (use "git add" to track)
✖ Failed to apply patches

https://github.com/nodejs/node/actions/runs/4263580508

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Feb 25, 2023
CI Reliability 2023-02-25 nodejs/reliability#506
Open
28 tasks
trivikr
trivikr approved these changes Feb 27, 2023
View reviewed changes

@trivikr trivikr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@marco-ippolito

marco-ippolito commented Apr 19, 2023

Copy link
Copy Markdown
Member

it has already been updated to 1.52.0 by #46636, closing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito marco-ippolito closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. dependencies PRs that add, update, or configure Node.js dependencies. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @marco-ippolito @lpinca @trivikr @RafaelGSS @mcollina
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.