GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — debugger: fix behavior of { a: 1 } in the debugger repl by meixg · Pull Request #46924 · nodejs/node

Conversation

@meixg

@meixg meixg commented Mar 3, 2023

Copy link
Copy Markdown
Member

fix: #46808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run. labels Mar 3, 2023
BridgeAR
BridgeAR reviewed Mar 3, 2023
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is LGTM. I think we should add a test though?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ErickWendel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
jenthone
jenthone reviewed Mar 3, 2023
View reviewed changes
Comment thread lib/internal/debugger/inspect_repl.js Outdated

@jenthone jenthone Mar 3, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also should append lib/internal/debugger/inspect_repl.js to this comment:

node/lib/repl.js

Lines 417 to 421 in 31156a7

// It's confusing for `{ a : 1 }` to be interpreted as a block
// statement rather than an object literal. So, we first try
// to wrap it in parentheses, so that it will be interpreted as
// an expression. Note that if the above condition changes,
// lib/internal/repl/utils.js needs to be changed to match.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@meixg meixuguang
debugger: fix behavior of { a: 1 } in the debugger repl
e2a3f35 
fix: nodejs#46808
@meixg
meixg force-pushed the debugger-repl branch from f4c13b3 to e2a3f35 Compare April 24, 2024 04:15
@dario-piotrowicz dario-piotrowicz mentioned this pull request Mar 16, 2025
debugger: fix behavior of plain object exec in debugger repl #57498
Merged
@meixg

meixg commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

this can be closed, ref: #57498
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@meixg meixg closed this Mar 19, 2025
@meixg
meixg deleted the debugger-repl branch April 21, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR left review comments
+1 more reviewer
@jenthone jenthone jenthone left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Different behavior of { a: 1 } in the REPL and the debugger

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@meixg @jenthone @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.