GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update incorrect links by noel046 · Pull Request #47085 · nodejs/node

Conversation

@noel046

@noel046 noel046 commented Mar 14, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes: #47070

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Mar 14, 2023
This was referenced Mar 21, 2023
fixed links #47204
Closed
doc: fix incorrect links #47089
Closed
Fixed Incorrect Links #47103
Closed
@deokjinkim

deokjinkim commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

@noel046 Thank you for contribution. Commit title needs to be started with subsystem like doc: update incorrect links. Please follow Commit message guidelines.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@noel046 noel046 changed the title update incorrect links #47070 doc: update incorrect links Mar 24, 2023
@deokjinkim

deokjinkim commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

@noel046 For now, PR title is only changed. But we need to change commit title(not PR of github) in git.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Mar 26, 2023

Copy link
Copy Markdown
Member

@noel046 For now, PR title is only changed. But we need to change commit title(not PR of github) in git.

The merge commit will need to be removed too. I'll do that now and force push.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@noel046 @Trott
doc: update incorrect links
b358df1
@Trott
Trott force-pushed the Incorrect-links-#47070 branch from f9629a7 to b358df1 Compare March 26, 2023 02:59
@mscdex mscdex mentioned this pull request Mar 31, 2023
fixed broken link nodejs#47070 #47345
Closed
@Trott

Trott commented Apr 1, 2023

Copy link
Copy Markdown
Member

The CI failure is relevant. This breaks links in the single-page version of the doc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Apr 3, 2023
View reviewed changes
Comment thread doc/api/net.md
[`'drain'`]: #event-drain
[`'end'`]: #event-end
[`'error'`]: #event-error_1
[`'error'`]: #event-error-1

@Trott Trott Apr 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current anchor exists in our HTML docs. The new one does not. What is the motivation for this change? Is it to fix something in the GitHub markdown rendering of this doc?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ovflowd ovflowd Apr 3, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, on our tooling we replace dots with nothing and underscores with hyphens. You can see it here: https://github.com/nodejs/node/blob/main/tools/doc/html.mjs#L426 (We do the same on nodejs.dev here https://github.com/nodejs/nodejs.dev/blob/main/util-node/createSlug.js#L1)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Apr 7, 2023
Fixed incorrect links #47469
Closed
Incorrect links #47070
Closed
@mscdex

mscdex commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Please also add a

Fixes: https://github.com/nodejs/node/issues/47070

to the commit message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex mentioned this pull request Apr 8, 2023
Updated incorrect links #47476
Closed
@mscdex mscdex mentioned this pull request Apr 22, 2023
doc: Fixing incorrect links #47670
Closed
@mscdex

mscdex commented Apr 22, 2023

Copy link
Copy Markdown
Contributor

Can we get this merged soon? We've been getting more and more identical PRs for the same (or a subset of) changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd

ovflowd commented Apr 22, 2023

Copy link
Copy Markdown
Member

@mscdex did the issues Trott and me mentioned get resolved?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Apr 22, 2023

Copy link
Copy Markdown
Contributor

@ovflowd I don't know. However from my recollection we tend to give the first to submit a PR for a specific set of changes priority, but as this PR has been open for over a month with others willing to make the same changes, we need to decide whether to continue waiting or close this PR and give others a chance to make the changes needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

Superseded by #48194.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments
@ovflowd ovflowd ovflowd left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect links

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@noel046 @nodejs-github-bot @deokjinkim @Trott @mscdex @ovflowd @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.