GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix concurrent sparkplug by targos · Pull Request #47461 · nodejs/node

Conversation

@targos

@targos targos commented Apr 7, 2023

Copy link
Copy Markdown
Member

Trying #47450 (comment)

/cc @miladfarca @dinfuehr

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and lin72h reacted with eyes emoji
All reactions
  • 👀 2 reactions
targos added 2 commits April 7, 2023 09:41
@targos
deps: V8: cherry-pick 8f61b4133805
20a5e25
Original commit message:

    [heap] Cache ForegroundTaskRunner in CollectionBarrier

    The API doesn't allow us to invoke GetForegroundTaskRunner() from
    a background thread. We need to cache the task runner in the ctor
    of CollectionBarrier during heap setup.

    We can't create the CollectionBarrier inside Heap's ctor anymore
    because at that point the TaskRunner might not be set up (e.g. Node).

    Bug: v8:13902
    Change-Id: I814b9dbecb0ded673108bfb7b730e7c9338cf5f5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4403395
    Reviewed-by: Michael Lippautz <[email protected]>
    Commit-Queue: Dominik Inführ <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86981}

Refs: v8/v8@8f61b41
@targos
deps: V8: cherry-pick f820e706a0b9
8c5b8de
Original commit message:

    [heap] Cache GetForegroundTaskRunner in IncrementalMarkingJob

    Our API doesn't allow us to invoke GetForegroundTaskRunner() from
    a background thread. We need to cache the task runner in the ctor
    of IncrementalMarkingJob during heap setup.

    This is necessary because we may start incremental marking from
    background threads.

    Bug: v8:13902
    Change-Id: I938c9bf016e05145f1807c27fd477a7b6c859ca4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4405689
    Commit-Queue: Dominik Inführ <[email protected]>
    Reviewed-by: Michael Lippautz <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86983}

Refs: v8/v8@f820e70
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 7, 2023
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Apr 7, 2023
@targos targos added dont-land-on-v14.x labels Apr 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51038/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Dominik Inführ and others added 3 commits April 7, 2023 10:06
Dominik Inführ @targos
src: do not drain worker tasks on main thread
776a1cf
@targos
Revert "test: skip test-wasm-web-api on ARM"
067a20d
This reverts commit 65b79ab.
@targos
Revert "test: skip instantiateStreaming-bad-imports WPT"
81b1a41
This reverts commit 3cf65bd.
@targos
targos force-pushed the fix-concurrent-sparkplug branch from d61b80d to 81b1a41 Compare April 7, 2023 08:07
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51040/

richardlau reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos marked this pull request as draft April 8, 2023 08:22
@targos targos removed the dont-land-on-v14.x label May 3, 2023
@targos targos removed the dont-land-on-v19.x label Jun 4, 2023
@targos targos removed the dont-land-on-v16.x label Sep 27, 2023
@targos targos mentioned this pull request Jan 11, 2024
test-http2-large-file is flaky #47409
Closed
@targos targos closed this Jan 11, 2024
@targos
targos deleted the fix-concurrent-sparkplug branch January 11, 2024 12:50
@targos targos mentioned this pull request Sep 11, 2024
flaky: parallel/test-http2-large-write-multiple-requests #52550
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.