GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — fix: harden check for non-module in vm.modules linker by MikeRalphson · Pull Request #47583 · nodejs/node Conversation
|
|
Should we add a test? Also, cc @nodejs/vm. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@RaisinTen should that be a simple test of the exception type? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think so, yes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <[email protected]>
|
Have found the relevant test file and am working up the new test function. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Is there a way to run just one of, or a subset of, the tests? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yea, you can run |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @RaisinTen! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You can also use |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@MikeRalphson are you still working on the regression test or can somebody else pick this up? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in d1d5da2. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.