GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: skip v8's regress/regress-1320641 on ppc64 and s390x by joyeecheung · Pull Request #48814 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Jul 17, 2023

Copy link
Copy Markdown
Member

This breaks Node.js's V8 CI. We could turn them back on when it gets fixed on those platforms.

cc @nodejs/platform-s390 @nodejs/platform-ppc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
deps: skip v8's regress/regress-1320641 on ppc64 and s390x
d5b82d7 
This breaks Node.js's V8 CI. We could turn them back on when it
gets fixed on those platforms.
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 17, 2023
richardlau
richardlau approved these changes Jul 17, 2023
View reviewed changes
@richardlau

richardlau commented Jul 17, 2023

Copy link
Copy Markdown
Member

cc @nodejs/platform-s390 @nodejs/platform-ppc

FWIW the failure on our CI looks like
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5461/nodes=rhel8-s390x,v8test=v8test/consoleFull

10:38:08 === mjsunit/regress/regress-1320641 ===
10:38:08 --- stdout ---
10:38:08 /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8: RangeError: Array buffer allocation failed
10:38:08   const xs = new Uint16Array(3775336418);
10:38:08              ^
10:38:08 RangeError: Array buffer allocation failed
10:38:08     at new ArrayBuffer (<anonymous>)
10:38:08     at new Uint16Array (<anonymous>)
10:38:08     at foo (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8:14)
10:38:08     at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:12:1
10:38:08 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js --random-seed=96903975 --nohard-abort --testing-d8-test-runner --allow-natives-syntax
10:38:08 
10:38:08 ===
10:38:08 === 1 tests failed
10:38:08 ===
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Jul 17, 2023

Copy link
Copy Markdown
Member Author

Maybe this is a better fix https://chromium-review.googlesource.com/c/v8/v8/+/4689686
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the blocked PRs that are blocked by other issues or PRs. label Jul 17, 2023
@miladfarca

miladfarca commented Jul 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Not specific to ppc/s390. You can limit your virtual memory to 8 Gb with ulimit -Sv 8000000 and it should fail on any platform (Fails on x64 with a different msg as they have sandbox enabled).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes Jul 18, 2023
View reviewed changes
@joyeecheung

joyeecheung commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

Superseded by #48830
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @nodejs-github-bot @richardlau @miladfarca @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.