GeezerVison

Review requested:

• @nodejs/loaders
• @nodejs/modules

@JakobJingleheimer wondering if you have any clues as to what might be up with this asan test failure here?

Looking at the output, it seems all cases are reporting okay, which makes me think there's an async issue (something is not waiting as it should). No idea why this would be isolated to ASan.

The test output appears to stop on:

Loader hooks → should handle a throwing top-level body → should handle empty plain object

Perhaps error here is not defined (or worse, null):

Ah, no, we know it's not because of switch (error?.code).

I would guess something is unexpectedly throwing, and that's getting swallowed (and ESM worker would be the most likely suspect for swallowing it as we experienced that A LOT during the off-thread PR).

I would still look here for the source of the unexpected throw

Looking at the output, it seems all cases are reporting okay, which makes me think there’s an async issue (something is not waiting as it should). No idea why this would be isolated to ASan.

https://openjs-foundation.slack.com/archives/C053UCCP940/p1690842970936839:

is there a reason the ASan build failed in ^? it did error in one of the ESM loader tests… so maybe it’s related… but the output doesn’t seem to show why 🤔 maybe there’s some non-determinism involved?

From July 31, so this might’ve been introduced by one of the earlier recent loaders PRs. cc @izaakschroeder

CI: https://ci.nodejs.org/job/node-test-pull-request/53132/

CI: https://ci.nodejs.org/job/node-test-pull-request/53178/

CI: https://ci.nodejs.org/job/node-test-pull-request/53182/

CI: https://ci.nodejs.org/job/node-test-pull-request/53192/

CI: https://ci.nodejs.org/job/node-test-pull-request/53204/

CI: https://ci.nodejs.org/job/node-test-pull-request/53211/