GeezerVison is showing github.com — perf_hooks: fix for redundant validation check for number by pluris · Pull Request #49547 · nodejs/node
Conversation
It has been modified so that Type and range can be checked only with validateNumber.
Below is a modified reference to a similar case.
Refs: #45770
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
validateNumber(percentile, 'percentile');
|
|
|
if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
|
|
|
throw new ERR_OUT_OF_RANGE('percentile', '> 0 && <= 100', percentile);
|
|
|
validateNumber(percentile, 'percentile', 1, 100);
|
deokjinkim
Sep 8, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this approach before, but all the numbers between 0 and 1 are not allowed any more with this PR.
This(#45772 (comment)) is previous discussion.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pluris reacted with thumbs up emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deokjinkim Thank you for explaining the history. I'll close it.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
