GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove `@anonrig` from performance initiative by anonrig · Pull Request #49641 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Sep 13, 2023

Copy link
Copy Markdown
Member

I'll continue working on performance but I don't feel comfortable being the champion of the performance strategic initiative anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nikolalukovic reacted with thumbs up emoji revskill10, Nsttt, and nikolalukovic reacted with laugh emoji ArturoAtomplay and rluvaton reacted with confused emoji bricss, aduh95, benjamingr, UlisesGascon, MoLow, GeoffreyBooth, ssalbdivad, gregdaynes, bengl, VladSez, and 193 more reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 😄 3 reactions
  • 😕 2 reactions
  • ❤️ 203 reactions
@anonrig
doc: remove @anonrig from performance initiative
3312e73
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 13, 2023
bnb
bnb approved these changes Sep 13, 2023
View reviewed changes

@bnb bnb left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benjamingr
benjamingr approved these changes Sep 13, 2023
View reviewed changes
MoLow
MoLow approved these changes Sep 13, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work is highly appreciated, sorry to see you step back

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth, yellowflx, wobsoriano, RaisinTen, jazzypants1989, nerdymomocat, marvinhagemeister, Theofilos-Chamalis, ljharb, VityaSchel, and 9 more reacted with thumbs up emoji
All reactions
  • 👍 19 reactions
UlisesGascon
UlisesGascon approved these changes Sep 13, 2023
View reviewed changes
jasnell
jasnell approved these changes Sep 13, 2023
View reviewed changes
@Uzlopak

This comment has been minimized.

Sign in to view
@Jarred-Sumner

Jarred-Sumner commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

i'm sorry
t3dotgg, AdditionAddict, AlexErrant, nickserv, greg-hammond, 0xRapid, datsfilipe, yellowflx, bnb, andresribeiro, and 116 more reacted with heart emoji
All reactions
  • ❤️ 126 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmanders

joshmanders commented Sep 14, 2023

Copy link
Copy Markdown

I wish the community wasn't so toxic. Thank you for all your hard work. <3
marvinhagemeister, chez14, Theofilos-Chamalis, AbdelrahmanDwedar, logotip4ik, joao-conde, slavikdenis, Monfernape, bhupeshpr25, datejer, and 8 more reacted with thumbs up emoji shellscape and jhigdon reacted with thumbs down emoji
All reactions
  • 👍 18 reactions
  • 👎 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoaoOtavioS

JoaoOtavioS commented Sep 14, 2023

Copy link
Copy Markdown

Thank you for everything you did.

[in Portuguese] Obrigado por tudo que fez e continua fazendo nesta comunidade, acredito que comentários ruins sempre existirão em todo lugar, raramente vejo algum brasileiro além do Erick Wendel tão empolgado com suas contribuições, portanto acho importante registrar aqui um pequeno agradecimento. Obrigado novamente.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr

trivikr commented Sep 14, 2023

Copy link
Copy Markdown
Member

Thank you, @anonrig, for your valuable contributions to improving Node.js performance ❤️

I hope you come back stronger after a brief break, to champion the performance strategic initiative again!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fox1t

fox1t commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

This makes me so sad. The worst part of the Internet fucked up the good part of it again. Thanks for everything you did, and you will do from now on.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 14, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dszymon, heyojules, andreujuanc, agustinusnathaniel, dca123, and joshuawootonn reacted with thumbs up emoji
All reactions
  • 👍 6 reactions
@manekinekko

manekinekko commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Thank you for your valuable contributions @anonrig ❤️
andreujuanc reacted with thumbs up emoji andreujuanc and Qard reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Sep 14, 2023
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 14, 2023
aduh95
aduh95 approved these changes Sep 14, 2023
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2023
@brunogrcsada

brunogrcsada commented Sep 14, 2023

Copy link
Copy Markdown

Thank you @anonrig for all of the hours you have put in, and like everyone here I'm so sorry about all of the toxicity at the moment!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bdbch

bdbch commented Sep 14, 2023

Copy link
Copy Markdown

While I tried out many NPM alternatives I always came back to NPM. Thanks for your work – I can't imagine the pressure / feeling you have. I always feel like I'm a worse developer than others but being consumed by a hypetrain must feel super bad. You have my sympathies.

People really need to chill and realize that there is a human behind every line of code (most of the time).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin

mertcanaltin commented Sep 14, 2023

Copy link
Copy Markdown
Member

Thank you very much for everything ❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Sep 14, 2023
View reviewed changes
@Cadienvan

Cadienvan commented Sep 14, 2023

Copy link
Copy Markdown

I can't tell you how much I appreciate you and the job you do daily for the Node project.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nigelnindodev

nigelnindodev commented Sep 14, 2023

Copy link
Copy Markdown

Damn. Keep on with the good work in whatever you choose to focus on next.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tony-go
tony-go approved these changes Sep 14, 2023
View reviewed changes

@tony-go tony-go left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sad to see this. Really appreciate your energy, @anonrig; thanks to this energy, I learned to push back my fear about touching the codebase.

Keep that please 🙏🏼

Love you bro ❤️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ovflowd
ovflowd approved these changes Sep 14, 2023
View reviewed changes

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort of Pull Request that approving just feels wrong.

I'm so sorry for everything you went through, and I hope you're able to take some quality personal time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rluvaton reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Qard
Qard approved these changes Sep 14, 2023
View reviewed changes

@Qard Qard left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I greatly appreciate all the amazing work you've done for Node.js performance! We need more people that care so much about improving the performance of Node.js. Take care, Yagiz! ❤️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tniessen
tniessen approved these changes Sep 14, 2023
View reviewed changes
@rluvaton

rluvaton commented Sep 14, 2023

Copy link
Copy Markdown
Member

As soon as I saw that I said noooooooo, wish you the best!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sheplu
sheplu approved these changes Sep 14, 2023
View reviewed changes

@sheplu sheplu left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels wrong to LGTM so LBTM !

You did and are doing amazing work! Thanks for all your contributions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cozzbie
cozzbie reviewed Sep 14, 2023
View reviewed changes

@cozzbie cozzbie left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs nodejs deleted a comment from mikelerch Sep 14, 2023
@nodejs nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023
@benjamingr benjamingr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 14, 2023
@nodejs nodejs unlocked this conversation Sep 14, 2023
@benjamingr benjamingr added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Sep 14, 2023
@github-actions

github-actions Bot commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.
benjamingr, Cadienvan, MoLow, marco-ippolito, and Linkgoron reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49641
✔  Done loading data for nodejs/node/pull/49641
----------------------------------- PR info ------------------------------------
Title      doc: remove `@anonrig` from performance initiative (#49641)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:perf-strategic-initiative -> nodejs:main
Labels     doc, fast-track, author ready
Commits    1
 - doc: remove `@anonrig` from performance initiative
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Darshan Sen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Marco Ippolito 
Reviewed-By: Claudio Wunder 
Reviewed-By: Stephen Belanger 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Darshan Sen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Marco Ippolito 
Reviewed-By: Claudio Wunder 
Reviewed-By: Stephen Belanger 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 13 Sep 2023 20:44:31 GMT
   ✔  Approvals: 11
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625430602
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625509384
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625535709
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625548463
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626092103
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626250563
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626261122
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626399738
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627144546
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627158595
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627214544
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6189910533
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023
@Trott

Trott commented Sep 14, 2023

Copy link
Copy Markdown
Member

Landed in ba28cd8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcollina mcollina mcollina approved these changes
@Qard Qard Qard approved these changes
@jasnell jasnell jasnell approved these changes
@bnb bnb bnb approved these changes
@benjamingr benjamingr benjamingr approved these changes
@tniessen tniessen tniessen approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@MoLow MoLow MoLow approved these changes
@ovflowd ovflowd ovflowd approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+3 more reviewers
@cozzbie cozzbie cozzbie left review comments
@sheplu sheplu sheplu approved these changes
@tony-go tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@anonrig @nodejs-github-bot @Uzlopak @Jarred-Sumner @joshmanders @JoaoOtavioS @trivikr @fox1t @manekinekko @brunogrcsada @bdbch @mertcanaltin @Cadienvan @nigelnindodev @rluvaton @Trott @mcollina @Qard @jasnell @bnb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.