GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — fs: improve error performance of `chownSync` by anonrig · Pull Request #49748 · nodejs/node Conversation
Member
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
RaisinTen
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
targos
reviewed
Uh oh!
There was an error while loading. Please reload this page.
anonrig
force-pushed
the
fs-improve-chownsync
branch
from
a67ad16 to
187fb83
Compare
|
There was an error while loading. Please reload this page.
|
Have you tried typing this function in the REPL and see if the system call happens before you type enter? (perhaps both our REPL and the DevTools console, we use different flags for them) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
86a17b5 to
d1ed9ff
Compare
|
Force pushed to resolve conflicts. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this is not the right way to change the error throwing behavior. See #49593 (comment)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This needs a rebase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing in favor of #49962 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.