GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: modify int to uint16_t for `HostPort` by pluris · Pull Request #49845 · nodejs/node

Conversation

@pluris

@pluris pluris commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

I modified Todo of HostPort.
For HostPort, int was modified to uint16_t.

Refs: #24772

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 25, 2023
@pluris
pluris force-pushed the feat/fix_todo_port branch from fc26d3e to c6c00ce Compare September 25, 2023 02:23
@pluris pluris changed the title src: modify int to uint16_t for src: modify int to uint16_t for HostPort Sep 25, 2023
pluris
src: modify int to uint16_t fori HostPort
acba84f
@pluris
pluris force-pushed the feat/fix_todo_port branch from c6c00ce to acba84f Compare September 25, 2023 02:31
@anonrig

anonrig commented Sep 25, 2023

Copy link
Copy Markdown
Member

Duplicate of #49151
pluris reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig marked this as a duplicate of #49151 Sep 25, 2023
@pluris pluris closed this Sep 25, 2023
@pluris

pluris commented Sep 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@anonrig Thank you your comment. I missed opened PR. 😭
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pluris
pluris deleted the feat/fix_todo_port branch November 8, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pluris @anonrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.