GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: deflake test-runner-watch-mode by MoLow · Pull Request #49997 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Oct 1, 2023

Copy link
Copy Markdown
Member

Fixes: #49985

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MoLow
test: deflake test-runner-watch-mode
0eb22f7
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 1, 2023
@MoLow

MoLow commented Oct 1, 2023

Copy link
Copy Markdown
Member Author

stress test: https://ci.nodejs.org/view/All/job/node-stress-single-test/452/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Oct 1, 2023
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the stress test passes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MoLow

MoLow commented Oct 2, 2023

Copy link
Copy Markdown
Member Author

Stress test passed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow marked this pull request as ready for review October 2, 2023 06:11
@MoLow
MoLow requested review from anonrig and benjamingr October 2, 2023 06:11
atlowChemi
atlowChemi approved these changes Oct 2, 2023
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54457/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented Oct 2, 2023

Copy link
Copy Markdown
Member Author

didnt seem to solve the issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 2, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Oct 3, 2023
CI Reliability 2023-10-03 nodejs/reliability#682
Open
18 tasks
StefanStojanovic
StefanStojanovic approved these changes Oct 3, 2023
View reviewed changes
This was referenced Oct 4, 2023
CI Reliability 2023-10-04 nodejs/reliability#683
Open
CI Reliability 2023-10-05 nodejs/reliability#684
Open
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 17, 2023
test: set test-runner-watch-mode as flaky #50221
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig

anonrig commented Oct 18, 2023

Copy link
Copy Markdown
Member

didnt seem to solve the issue

Is this still the case @MoLow?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 19, 2023
CI Reliability 2023-10-19 nodejs/reliability#691
Open
CI Reliability 2023-10-20 nodejs/reliability#692
Open
CI Reliability 2023-10-21 nodejs/reliability#693
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55289/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller

avivkeller commented Apr 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Hi! It's been a while since any activity on this PR, but it has several approvals. This comment will bump it to the front of the PR page so more people can see (and implement) this change.

If you still want to pursue this, please make sure that this change is still relevant.

This comment is an attempt to resolve older pull requests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/505/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow closed this May 24, 2024
@MoLow
MoLow deleted the deflake-test-runner-watch-mode branch May 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr
@anonrig anonrig Awaiting requested review from anonrig

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel.test-runner-watch-mode is flaky

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@MoLow @nodejs-github-bot @anonrig @avivkeller @aduh95 @lpinca @cjihrig @StefanStojanovic @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.